-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Description
Part of the changes from #43015 are being reverted as part of #45295 as they were not correct. Some other tests are ignored but that's tracked by #42850
There are more changes that may need to be reviewed by the SDK team:
-
It_fails_to_build_if_targeting_a_higher_framework_than_is_supported
: this changed the test argument fromnetcoreapp9.1
tonetcoreapp10.1
. I don't see a reason why the test would fail withnetcoreapp9.1
so to me, the test should be tested both with netcoreapp9.1 and netcoreapp10.1. Add netcoreapp9.1 tfm to It_fails_to_build_if_targeting_a_higher_framework_than_is_supported test #45409 - Bunch of test assets were updated from
<TargetFramework>$(CurrentTargetFramework)</TargetFramework>
to net9.0 which is suspicious to me. Update the hardcoded tfm to the current #45720 - WorkloadTests used to use ToolsetInfo.CurrentTargetFramework but are now using hardcoded net9.0. Investigate failures in WorkloadTests when using net10.0 workload manifests #45516
- WebProjectsTests.CanShowHelp_Mvc.verified.txt is showing
-f, --framework <net10.0|net6.0|net7.0|net8.0> The target framework for the project.
which is strange that net9.0 is missing from there while old EOL TFMs are there. Add support for .NET 9.0 web project templates #45423 - Changes in CommonTemplatesTests looks suspicious to me. Create project templates target to 10.0 #44349
-
It_defaults_preview_AnalysisLevel_to_the_next_tfm
is fixed and is ignored in Fix warning level calculation for .NET 10 #45295 with link to this issue.
NOTE: It's possible that some of the test changes are not wrong per-se and are temporary until other parts of the ecosystem release their stuff. In that case it's still good to have a tracking issue to revert when the time comes
cc @baronfel