-
Notifications
You must be signed in to change notification settings - Fork 1.1k
ApplicationIcon does not work when cross building win-x64 from Linux #3943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It's not limited to icons. Version information isn't present, either. No PE resources at all are added to the Win32 EXE file when published on Linux. Using the "peres" utility from "pev", If built on Linux: Still present on the latest build: SDK 3.1.200, Host 3.1.2/916b5cba26 on both Linux and Windows. |
Yes. I found out because I switched to ubuntu for building new releases with GitHub Actions, so switched back to Windows. Hopefully will be fixed. Building for Windows should remain on Windows unless this is fixed. |
Still not working on |
It would be nice if someone from Microsoft could respond to this about what the reason is and when it will be fixed. |
+1, I just found out this through a Google search because my app built on the cloud in Docker wasn't having an app icon. Is there any timeline from the MS team to fix this? |
I've identified the same problem cross building win-x64 from macOS ( |
@eduherminio there is solutions, look at my workaround with wine and rcedit. |
May be a duplicate of dotnet/runtime#3828. |
Avoid cross-compiling Linux -> Windows, as a workaround until dotnet/sdk#3943 and dotnet/runtime#3828 are tackled
For anyone else that landed on this thread, confirming 6.0.1 is still affected |
…untime#3828 and dotnet/sdk#3943 are fixed. Re-wrote bond voucher parsing to use a map with updated credit values, resolves #1 Added caching of previous state for massive performance gains (AppData json). Added detection when not run from command line to wait for input before closing.
@NicolasDorier According to dotnet/runtime#3828 this is scheduled for 7.0.0 again. |
I can confirm that 7.0 is still affected. :-( |
I believe 8.0 now fixed it and this can be closed (dotnet/core#8439 (comment)), didn't try yet though. |
Was able to test my pipeline with |
Seems to work on my side with .NET 8 SDK, the fix might have been dotnet/runtime#3828. |
Uh oh!
There was an error while loading. Please reload this page.
How to reproduce
On linux (using Buster 3.0.101):
dotnet new console # Add myicon.ico to the project dotnet publish --runtime win-x64 -p:ApplicationIcon=myicon.ico
Grab
bin/Debug/netcoreapp3.0/publish/*.exe
Notice that the executable does not show any icon on windows explorer.
The same process on windows works as expected.
Expected
The executable should have the application icon properly set.
Workaround
Post process the
.exe
with wine andrcedit.exe
.https://github.com/btcpayserver/BTCPayServer.Vault/blob/abf575728b9b1f64bade6cd3a590ed8ac8baf6ee/Build/build.win-x64.Dockerfile#L28
Version
The text was updated successfully, but these errors were encountered: