Skip to content

Commit 8c8ceb7

Browse files
committed
Revert bad test changes
1 parent cc259b5 commit 8c8ceb7

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

test/Microsoft.NET.Build.Tests/GivenThatWeWantToFloatWarningLevels.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public GivenThatWeWantToFloatWarningLevels(ITestOutputHelper log) : base(log)
1313
}
1414

1515
[InlineData(targetFrameworkNet6, "6")]
16-
[InlineData(ToolsetInfo.CurrentTargetFramework, "1")]
16+
[InlineData(ToolsetInfo.CurrentTargetFramework, ToolsetInfo.CurrentTargetFrameworkVersion)]
1717
[InlineData(targetFrameworkNetFramework472, "4")]
1818
[RequiresMSBuildVersionTheory("16.8")]
1919
public void It_defaults_WarningLevel_To_The_Current_TFM_When_Net(string tfm, string warningLevel)
@@ -59,7 +59,7 @@ static void Main()
5959
}
6060

6161
[InlineData(1, "1")]
62-
[InlineData(null, "1")]
62+
[InlineData(null, ToolsetInfo.CurrentTargetFrameworkVersion)]
6363
[RequiresMSBuildVersionTheory("16.8")]
6464
public void It_always_accepts_user_defined_WarningLevel(int? warningLevel, string expectedWarningLevel)
6565
{
@@ -156,7 +156,7 @@ static void Main()
156156
buildResult.StdErr.Should().Be(string.Empty);
157157
}
158158

159-
[InlineData(ToolsetInfo.CurrentTargetFramework, ToolsetInfo.CurrentTargetFrameworkVersion)]
159+
[InlineData(ToolsetInfo.CurrentTargetFramework, ToolsetInfo.NextTargetFrameworkVersion)]
160160
[RequiresMSBuildVersionTheory("16.8")]
161161
public void It_defaults_preview_AnalysisLevel_to_the_next_tfm(string currentTFM, string nextTFMVersionNumber)
162162
{

test/Microsoft.NET.Build.Tests/GivenThatWeWantToUseBinaryFormatter.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@ public void It_warns_when_targeting_certain_frameworks_and_not_using_pragma_supp
133133

134134
[Theory]
135135
[InlineData("net9.0")]
136+
[InlineData(ToolsetInfo.CurrentTargetFramework)]
136137
public void It_errors_when_targeting_certain_frameworks_and_not_using_pragma_suppressions(string targetFramework)
137138
{
138139
var testProject = new TestProject()
@@ -159,6 +160,7 @@ public void It_errors_when_targeting_certain_frameworks_and_not_using_pragma_sup
159160

160161
[Theory]
161162
[InlineData("net9.0")]
163+
[InlineData(ToolsetInfo.CurrentTargetFramework)]
162164
public void It_allows_downgrading_errors_to_warnings_via_project_config(string targetFramework)
163165
{
164166
var testProject = new TestProject()

0 commit comments

Comments
 (0)