Skip to content

EventPipe shutdown and EventPipeEventDispatcher aren't coordinated properly #90472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
davmason opened this issue Aug 13, 2023 · 2 comments · Fixed by #90053
Closed

EventPipe shutdown and EventPipeEventDispatcher aren't coordinated properly #90472

davmason opened this issue Aug 13, 2023 · 2 comments · Fixed by #90053
Labels
area-System.Diagnostics.Tracing EventPipe
Milestone
8.0.0

Comments

@davmason
Copy link
Contributor

If a program returns from main it will clean up EventPipe by calling ep_shutdown, but the EventPipeEventDispatcher thread is still running and may AV when it is trying to use memory owned by EventPipe's buffers.

We should either let the EventPipeEventDispatcher session run past shutdown or put in the appropriate synchronization.
@davmason davmason added this to the 9.0.0 milestone Aug 13, 2023
@ghost
Copy link

ghost commented Aug 13, 2023

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

If a program returns from main it will clean up EventPipe by calling ep_shutdown, but the EventPipeEventDispatcher thread is still running and may AV when it is trying to use memory owned by EventPipe's buffers.

We should either let the EventPipeEventDispatcher session run past shutdown or put in the appropriate synchronization.

Author: davmason
Assignees: -
Labels:

area-System.Diagnostics.Tracing, EventPipe
Milestone: 9.0.0

@davmason davmason mentioned this issue Aug 13, 2023
Merged
@davmason davmason linked a pull request Aug 14, 2023 that will close this issue
Fix deadlock in EventPipeEventDispatcher #90053
Merged
@tommcdon tommcdon modified the milestones: 9.0.0, 8.0.0 Aug 14, 2023
@tommcdon
Copy link
Member

Changed the milestone 8.0 as this was fixed in 8.0

@ghost ghost locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Diagnostics.Tracing EventPipe
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Fix deadlock in EventPipeEventDispatcher davmason/runtime
2 participants
@davmason @tommcdon