Skip to content

SuppressGCTransitionAttribute hitting asserts in the JIT #39726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jkotas opened this issue Jul 21, 2020 · 2 comments
Closed

SuppressGCTransitionAttribute hitting asserts in the JIT #39726

jkotas opened this issue Jul 21, 2020 · 2 comments
Assignees
@erozenfeld
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI bug
Milestone
5.0.0

Comments

@jkotas
Copy link
Member

jkotas commented Jul 21, 2020

See #39474 (comment) for details and repro.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI untriaged New issue has not been triaged by the area owner labels Jul 21, 2020
@jkotas jkotas removed the untriaged New issue has not been triaged by the area owner label Jul 21, 2020
@jkotas jkotas added this to the 5.0.0 milestone Jul 21, 2020
@jkotas jkotas added the bug label Jul 21, 2020
@jkotas
Copy link
Member Author

jkotas commented Jul 21, 2020

cc @erozenfeld

@jkotas jkotas mentioned this issue Jul 21, 2020
Closed
2 tasks
@erozenfeld erozenfeld mentioned this issue Jul 24, 2020
Merged
erozenfeld added a commit to erozenfeld/runtime that referenced this issue Jul 24, 2020
@erozenfeld
Fix GC Poll inlining.
8017e30 
* Don't inline GC polls in cold basic blocks.
* Allow GC poll inlining in basic blocks with `BBF_LOOP_PREHEADER` or `BBF_RETLESS_CALL` set.

This fixes one of the assert seen in dotnet#39474 (comment)

Contributes to resolving dotnet#39726.
@erozenfeld erozenfeld mentioned this issue Jul 24, 2020
Merged
erozenfeld added a commit that referenced this issue Jul 24, 2020
@erozenfeld
Fix GC Poll inlining. (#39881)
3665779 
* Don't inline GC polls in cold basic blocks.
* Allow GC poll inlining in basic blocks with `BBF_LOOP_PREHEADER` or `BBF_RETLESS_CALL` set.

This fixes one of the assert seen in #39474 (comment)

Contributes to resolving #39726.
@erozenfeld
Copy link
Member

Resolved by #39878 and #39881.

Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this issue Aug 10, 2020
@erozenfeld @Jacksondr5
Fix GC Poll inlining. (dotnet#39881)
0c45c49 
* Don't inline GC polls in cold basic blocks.
* Allow GC poll inlining in basic blocks with `BBF_LOOP_PREHEADER` or `BBF_RETLESS_CALL` set.

This fixes one of the assert seen in dotnet#39474 (comment)

Contributes to resolving dotnet#39726.
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@erozenfeld erozenfeld

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI bug
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
3 participants
@jkotas @erozenfeld @Dotnet-GitSync-Bot