Skip to content

JIT: Consider making handles their own node type #104636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakobbotsch opened this issue Jul 9, 2024 · 3 comments
Open

JIT: Consider making handles their own node type #104636

jakobbotsch opened this issue Jul 9, 2024 · 3 comments
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone

Comments

@jakobbotsch
Copy link
Member

jakobbotsch commented Jul 9, 2024

The JIT has had a number of bugs related to the fact that handles are special and cannot participate in various opts, even though we represent them as GT_CNS_INT. #104634 is one latest example.
I think we should consider introducing a dedicated node type for the (opaque) handles to make these bugs less likely to be introduced.

cc @dotnet/jit-contrib

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 9, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jul 9, 2024
@jakobbotsch jakobbotsch added this to the 10.0.0 milestone Jul 9, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Jul 9, 2024
@SingleAccretion
Copy link
Contributor

Consideration: under Jit (!opts.compReloc) it is ok to dissolve handles (they have their final values). It is only under AOT that handles are special.

@jakobbotsch
Copy link
Member Author

@SingleAccretion Yeah, that's what I was alluding to by the "(opaque)". Though it would be nice to remove the handle flags from GT_CNS_INT as well, but we use those for a few things (mostly to annotate disassembly, I think), so we probably wouldn't be able to do that if we left the runtime JIT handles as GT_CNS_INT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

No branches or pull requests

2 participants