Skip to content

Commit feb1fe2

Browse files
layomiaericstj
andauthored
Use config binding generator in Microsoft.Extensions.Logging.Configuration assembly (#87935)
* Use config binding generator in Microsoft.Extensions.Logging.Configuration assembly * Suppress package dependency to Microsoft.Extensions.Configuration.Binder --------- Co-authored-by: Eric StJohn <[email protected]>
1 parent 8b2dc46 commit feb1fe2

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/libraries/Microsoft.Extensions.Logging.Configuration/src/LoggerFilterConfigureOptions.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
// The .NET Foundation licenses this file to you under the MIT license.
33

44
using System;
5-
using System.Diagnostics.CodeAnalysis;
65
using Microsoft.Extensions.Configuration;
76
using Microsoft.Extensions.Options;
87

@@ -52,8 +51,6 @@ private void LoadDefaultConfigValues(LoggerFilterOptions options)
5251
}
5352
}
5453

55-
[UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:RequiresUnreferencedCode",
56-
Justification = "IConfiguration.GetValue is safe when T is a bool.")]
5754
bool GetCaptureScopesValue(LoggerFilterOptions options) => _configuration.GetValue(nameof(options.CaptureScopes), options.CaptureScopes);
5855
}
5956

src/libraries/Microsoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Logging.Configuration.csproj

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
<PropertyGroup>
44
<TargetFrameworks>$(NetCoreAppCurrent);$(NetCoreAppPrevious);$(NetCoreAppMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks>
55
<EnableDefaultItems>true</EnableDefaultItems>
6+
<EnableConfigurationBindingGenerator>true</EnableConfigurationBindingGenerator>
67
<IsPackable>true</IsPackable>
78
<PackageDescription>Configuration support for Microsoft.Extensions.Logging.</PackageDescription>
89
</PropertyGroup>
@@ -15,7 +16,6 @@
1516
</ItemGroup>
1617

1718
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp'">
18-
<Compile Include="$(CoreLibSharedDir)System\Diagnostics\CodeAnalysis\UnconditionalSuppressMessageAttribute.cs" />
1919
<Compile Include="$(CoreLibSharedDir)System\Diagnostics\CodeAnalysis\DynamicallyAccessedMembersAttribute.cs" />
2020
<Compile Include="$(CoreLibSharedDir)System\Diagnostics\CodeAnalysis\DynamicallyAccessedMemberTypes.cs" />
2121
<Compile Include="$(CoreLibSharedDir)System\Diagnostics\CodeAnalysis\RequiresUnreferencedCodeAttribute.cs" />
@@ -36,4 +36,8 @@
3636
<ProjectReference Include="$(LibrariesProjectRoot)Microsoft.Extensions.Options.ConfigurationExtensions\src\Microsoft.Extensions.Options.ConfigurationExtensions.csproj" />
3737
</ItemGroup>
3838

39+
<ItemGroup>
40+
<ProjectReference Include="$(LibrariesProjectRoot)Microsoft.Extensions.Configuration.Binder\gen\Microsoft.Extensions.Configuration.Binder.SourceGeneration.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="true" PrivateAssets="All" />
41+
</ItemGroup>
42+
3943
</Project>

0 commit comments

Comments
 (0)