Skip to content

Commit d5f6605

Browse files
authored
SPMI: Update -metrics passthrough (#80775)
jit-analyze no longer accepts comma-separated metrics after dotnet/jitutils#362, instead requiring each metric to be specified separately on the command line.
1 parent 4e0195e commit d5f6605

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/coreclr/scripts/superpmi.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ def add_core_root_arguments(parser, build_type_default, build_type_help):
341341
asm_diff_parser.add_argument("--gcinfo", action="store_true", help="Include GC info in disassembly (sets DOTNET_JitGCDump; requires instructions to be prefixed by offsets).")
342342
asm_diff_parser.add_argument("--debuginfo", action="store_true", help="Include debug info after disassembly (sets DOTNET_JitDebugDump).")
343343
asm_diff_parser.add_argument("-tag", help="Specify a word to add to the directory name where the asm diffs will be placed")
344-
asm_diff_parser.add_argument("-metrics", action="append", help="Metrics option to pass to jit-analyze. Can be specified multiple times, or pass comma-separated values.")
344+
asm_diff_parser.add_argument("-metrics", action="append", help="Metrics option to pass to jit-analyze. Can be specified multiple times, one for each metric.")
345345
asm_diff_parser.add_argument("--diff_with_release", action="store_true", help="Specify if this is asmdiff using release binaries.")
346346
asm_diff_parser.add_argument("--git_diff", action="store_true", help="Produce a '.diff' file from 'base' and 'diff' folders if there were any differences.")
347347

@@ -1788,7 +1788,8 @@ def create_exception():
17881788
jit_analyze_summary_file = os.path.join(asm_root_dir, "summary.md")
17891789
command = [ jit_analyze_path, "--md", jit_analyze_summary_file, "-r", "--base", base_asm_location, "--diff", diff_asm_location ]
17901790
if self.coreclr_args.metrics:
1791-
command += [ "--metrics", ",".join(self.coreclr_args.metrics) ]
1791+
for metric in self.coreclr_args.metrics:
1792+
command += [ "--metrics", metric ]
17921793
elif base_bytes is not None and diff_bytes is not None:
17931794
command += [ "--override-total-base-metric", str(base_bytes), "--override-total-diff-metric", str(diff_bytes) ]
17941795

0 commit comments

Comments
 (0)