Remove usage of Newtonsoft.Json from host test assets (#84745)

elinor-fung · web-flow · commit d27142772e8d · 2023-04-13T11:58:07.000-07:00
diff --git a/src/installer/tests/Assets/TestProjects/StandaloneApp/Program.cs b/src/installer/tests/Assets/TestProjects/StandaloneApp/Program.cs
@@ -13,9 +13,6 @@ public static void Main(string[] args)
             Console.WriteLine("Hello World!");
             Console.WriteLine(string.Join(Environment.NewLine, args));
             Console.WriteLine(RuntimeInformation.FrameworkDescription);
-
-            // A small operation involving NewtonSoft.Json to ensure the assembly is loaded properly
-            var t = typeof(Newtonsoft.Json.JsonReader);
         }
     }
 }
diff --git a/src/installer/tests/Assets/TestProjects/StandaloneApp/StandaloneApp.csproj b/src/installer/tests/Assets/TestProjects/StandaloneApp/StandaloneApp.csproj
@@ -7,8 +7,4 @@
     <RuntimeFrameworkVersion>$(MNAVersion)</RuntimeFrameworkVersion>
   </PropertyGroup>
 
-  <ItemGroup>
-    <PackageReference Include="Newtonsoft.Json" Version="$(NewtonsoftJsonVersion)" />
-  </ItemGroup>
-
 </Project>
diff --git a/src/installer/tests/Assets/TestProjects/StandaloneApp20/Program.cs b/src/installer/tests/Assets/TestProjects/StandaloneApp20/Program.cs
@@ -11,9 +11,6 @@ public static void Main(string[] args)
         {
             Console.WriteLine("Hello World!");
             Console.WriteLine(string.Join(Environment.NewLine, args));
-
-            // A small operation involving NewtonSoft.Json to ensure the assembly is loaded properly
-            var t = typeof(Newtonsoft.Json.JsonReader);
         }
     }
 }
diff --git a/src/installer/tests/Assets/TestProjects/StandaloneApp20/StandaloneApp20.csproj b/src/installer/tests/Assets/TestProjects/StandaloneApp20/StandaloneApp20.csproj
@@ -8,8 +8,4 @@
     <RuntimeFrameworkVersion>2.0.7</RuntimeFrameworkVersion>
   </PropertyGroup>
 
-  <ItemGroup>
-    <PackageReference Include="Newtonsoft.Json" Version="$(NewtonsoftJsonVersion)" />
-  </ItemGroup>
-
 </Project>
diff --git a/src/installer/tests/Assets/TestProjects/StandaloneApp21/Program.cs b/src/installer/tests/Assets/TestProjects/StandaloneApp21/Program.cs
@@ -11,9 +11,6 @@ public static void Main(string[] args)
         {
             Console.WriteLine("Hello World!");
             Console.WriteLine(string.Join(Environment.NewLine, args));
-
-            // A small operation involving NewtonSoft.Json to ensure the assembly is loaded properly
-            var t = typeof(Newtonsoft.Json.JsonReader);
         }
     }
 }
diff --git a/src/installer/tests/Assets/TestProjects/StandaloneApp21/StandaloneApp21.csproj b/src/installer/tests/Assets/TestProjects/StandaloneApp21/StandaloneApp21.csproj
@@ -8,8 +8,4 @@
     <RuntimeFrameworkVersion>2.1.0</RuntimeFrameworkVersion>
   </PropertyGroup>
 
-  <ItemGroup>
-    <PackageReference Include="Newtonsoft.Json" Version="$(NewtonsoftJsonVersion)" />
-  </ItemGroup>
-
 </Project>
diff --git a/src/installer/tests/Assets/TestUtils/TestProjects.props b/src/installer/tests/Assets/TestUtils/TestProjects.props
@@ -13,7 +13,5 @@
       win-x86 tests that assumed a win-x64 app host RID based on the runner SDK.
     -->
     <AppHostRuntimeIdentifier>$(TestTargetRid)</AppHostRuntimeIdentifier>
-
-    <NewtonsoftJsonVersion>13.0.1</NewtonsoftJsonVersion>
   </PropertyGroup>
 </Project>

Original file line number	Diff line number	Diff line change
`@@ -13,9 +13,6 @@ public static void Main(string[] args)`
`13`	`13`	`Console.WriteLine("Hello World!");`
`14`	`14`	`Console.WriteLine(string.Join(Environment.NewLine, args));`
`15`	`15`	`Console.WriteLine(RuntimeInformation.FrameworkDescription);`
`16`		`-`
`17`		`- // A small operation involving NewtonSoft.Json to ensure the assembly is loaded properly`
`18`		`- var t = typeof(Newtonsoft.Json.JsonReader);`
`19`	`16`	`}`
`20`	`17`	`}`
`21`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,9 +11,6 @@ public static void Main(string[] args)`
`11`	`11`	`{`
`12`	`12`	`Console.WriteLine("Hello World!");`
`13`	`13`	`Console.WriteLine(string.Join(Environment.NewLine, args));`
`14`		`-`
`15`		`- // A small operation involving NewtonSoft.Json to ensure the assembly is loaded properly`
`16`		`- var t = typeof(Newtonsoft.Json.JsonReader);`
`17`	`14`	`}`
`18`	`15`	`}`
`19`	`16`	`}`