Skip to content

Commit c105e7d

Browse files
authored
[wasm][mt] Fix System.Threading.Tasks.Parallel build (#97505)
* [wasm][mt] Fix System.Threading.Tasks.Parallel build Fixes #91583 and #91579 * Enable 5 more tests * Feedback * Fix typo
1 parent 0d81a5a commit c105e7d

File tree

5 files changed

+1
-7
lines changed

5 files changed

+1
-7
lines changed

src/libraries/System.Threading.Tasks.Parallel/src/System.Threading.Tasks.Parallel.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>$(NetCoreAppCurrent)</TargetFramework>
4+
<TargetFrameworks>$(NetCoreAppCurrent);$(NetCoreAppCurrent)-browser</TargetFrameworks>
55
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
66
<UseCompilerGeneratedDocXmlFile>false</UseCompilerGeneratedDocXmlFile>
77
</PropertyGroup>

src/libraries/System.Threading.Tasks.Parallel/tests/ParallelForTests.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -885,7 +885,6 @@ public static void TestParallelForPaths_Exceptions()
885885
}
886886

887887
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
888-
[ActiveIssue("https://github.com/dotnet/runtime/issues/91582", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))]
889888
public static void TestParallelScheduler()
890889
{
891890
ParallelOptions parallelOptions = new ParallelOptions();
@@ -993,7 +992,6 @@ public static void TestParallelScheduler()
993992
}
994993

995994
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
996-
[ActiveIssue("https://github.com/dotnet/runtime/issues/91541", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))]
997995
public static void TestInvokeDOPAndCancel()
998996
{
999997
ParallelOptions parallelOptions = null;

src/libraries/System.Threading.Tasks.Parallel/tests/ParallelLoopResultTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,6 @@ private static void OrderablePartitionerForEachPLRTest(
373373

374374
// Perform tests on various combinations of Stop()/Break()
375375
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
376-
[ActiveIssue("https://github.com/dotnet/runtime/issues/91579", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))]
377376
public static void SimultaneousStopBreakTests()
378377
{
379378
//

src/libraries/System.Threading.Tasks.Parallel/tests/RangePartitioner1Chunk.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ static void oneMoveNext(int length, bool isOrderable)
101101
/// </summary>
102102
/// <param name="length"></param>
103103
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
104-
[ActiveIssue("https://github.com/dotnet/runtime/issues/97396", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))]
105104
public static void IterationsWithDependency()
106105
{
107106
static void iterationsWithDependency(int length, int dependencyIndex)
@@ -167,7 +166,6 @@ public static void PFEDisposeEnum()
167166
/// Exception is expected and the enumerators are disposed
168167
/// </summary>
169168
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
170-
[ActiveIssue("https://github.com/dotnet/runtime/issues/91581", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))]
171169
public static void ExceptionOnMoveNext()
172170
{
173171
static void exceptionOnMoveNext(int length, int indexToThrow, bool isOrderable)

src/libraries/System.Threading.Tasks.Parallel/tests/RangePartitionerTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ namespace System.Threading.Tasks.Tests
1010
public static class RangePartitionerTests
1111
{
1212
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
13-
[ActiveIssue("https://github.com/dotnet/runtime/issues/97440", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))]
1413
public static void RunPartitionerStaticTest_SingleChunking()
1514
{
1615
CountdownEvent cde = new CountdownEvent(2);

0 commit comments

Comments
 (0)