Delete misc unnecessary code (#92764)

Author: jkotas

src/coreclr/nativeaot/Runtime/gcrhenv.cpp

@@ -503,7 +503,7 @@ uint32_t RedhawkGCInterface::GetGCDescSize(void * pType)
 
 COOP_PINVOKE_HELPER(FC_BOOL_RET, RhCompareObjectContentsAndPadding, (Object* pObj1, Object* pObj2))
 {
-    ASSERT(pObj1->GetMethodTable()->IsEquivalentTo(pObj2->GetMethodTable()));
+    ASSERT(pObj1->GetMethodTable() == pObj2->GetMethodTable());
     ASSERT(pObj1->GetMethodTable()->IsValueType());
 
     MethodTable * pEEType = pObj1->GetMethodTable();

src/coreclr/nativeaot/Runtime/inc/MethodTable.h

@@ -260,22 +260,6 @@ class MethodTable
         return (m_uFlags & OptionalFieldsFlag) != 0;
     }
 
-    bool IsEquivalentTo(MethodTable * pOtherEEType)
-    {
-        if (this == pOtherEEType)
-            return true;
-
-        MethodTable * pThisEEType = this;
-
-        if (pThisEEType->IsParameterizedType() && pOtherEEType->IsParameterizedType())
-        {
-            return pThisEEType->GetRelatedParameterType()->IsEquivalentTo(pOtherEEType->GetRelatedParameterType()) &&
-                pThisEEType->GetParameterizedTypeShape() == pOtherEEType->GetParameterizedTypeShape();
-        }
-
-        return false;
-    }
-
     // How many vtable slots are there?
     uint16_t GetNumVtableSlots()
         { return m_usNumVtableSlots; }
@@ -348,4 +332,3 @@ class MethodTable
 };
 
 #pragma warning(pop)
-

src/coreclr/nativeaot/System.Private.CoreLib/src/System/EETypePtr.cs

@@ -164,7 +164,7 @@ internal bool IsEnum
             {
                 // Q: When is an enum type a constructed generic type?
                 // A: When it's nested inside a generic type.
-                if (!(IsDefType))
+                if (!IsDefType)
                     return false;
 
                 // Generic type definitions that return true for IsPrimitive are type definitions of generic enums.

src/coreclr/vm/ceeload.cpp

@@ -2188,6 +2188,16 @@ ISymUnmanagedReader *Module::GetISymUnmanagedReaderNoThrow(void)
     RETURN (ret);
 }
 
+#if defined(HOST_AMD64)
+#define NATIVE_SYMBOL_READER_DLL W("Microsoft.DiaSymReader.Native.amd64.dll")
+#elif defined(HOST_X86)
+#define NATIVE_SYMBOL_READER_DLL W("Microsoft.DiaSymReader.Native.x86.dll")
+#elif defined(HOST_ARM)
+#define NATIVE_SYMBOL_READER_DLL W("Microsoft.DiaSymReader.Native.arm.dll")
+#elif defined(HOST_ARM64)
+#define NATIVE_SYMBOL_READER_DLL W("Microsoft.DiaSymReader.Native.arm64.dll")
+#endif
+
 ISymUnmanagedReader *Module::GetISymUnmanagedReader(void)
 {
     CONTRACT(ISymUnmanagedReader *)

src/coreclr/vm/ceeload.h

@@ -79,21 +79,6 @@ class EnCEEClassData;
 #define METHOD_STUBS_HASH_BUCKETS 11
 #define GUID_TO_TYPE_HASH_BUCKETS 16
 
-// The native symbol reader dll name
-#if defined(HOST_AMD64)
-#define NATIVE_SYMBOL_READER_DLL W("Microsoft.DiaSymReader.Native.amd64.dll")
-#elif defined(HOST_X86)
-#define NATIVE_SYMBOL_READER_DLL W("Microsoft.DiaSymReader.Native.x86.dll")
-#elif defined(HOST_ARM)
-#define NATIVE_SYMBOL_READER_DLL W("Microsoft.DiaSymReader.Native.arm.dll")
-#elif defined(HOST_ARM64)
-#define NATIVE_SYMBOL_READER_DLL W("Microsoft.DiaSymReader.Native.arm64.dll")
-#elif defined(HOST_LOONGARCH64)
-#define NATIVE_SYMBOL_READER_DLL W("Microsoft.DiaSymReader.Native.loongarch64.dll")
-#elif defined(HOST_RISCV64)
-#define NATIVE_SYMBOL_READER_DLL W("Microsoft.DiaSymReader.Native.riscv64.dll")
-#endif
-
 typedef DPTR(JITInlineTrackingMap) PTR_JITInlineTrackingMap;
 
 //