Skip to content

Commit 89ab2a9

Browse files
authored
Disable binder tracing test under gcstress (#100798)
1 parent e6c1a49 commit 89ab2a9

File tree

4 files changed

+6
-14
lines changed

4 files changed

+6
-14
lines changed

src/tests/Loader/binding/tracing/BinderTracingTest.Basic.csproj

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,4 @@
11
<Project Sdk="Microsoft.NET.Sdk">
2-
<PropertyGroup>
3-
<!-- TestAssemblyLoadContext.Load called from the finalizer -->
4-
<UnloadabilityIncompatible>true</UnloadabilityIncompatible>
5-
<!-- Dynamic assembly loads -->
6-
<NativeAotIncompatible>true</NativeAotIncompatible>
7-
</PropertyGroup>
82
<ItemGroup>
93
<Compile Include="BinderTracingTest.Basic.cs" />
104
<Compile Include="BinderTracingTest.DefaultProbing.cs" />

src/tests/Loader/binding/tracing/BinderTracingTest.ResolutionFlow.csproj

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
3-
<!-- Test creates non-collectible AssemblyLoadContext -->
4-
<UnloadabilityIncompatible>true</UnloadabilityIncompatible>
5-
<!-- Dynamic assembly loads -->
6-
<NativeAotIncompatible>true</NativeAotIncompatible>
7-
<RequiresProcessIsolation>true</RequiresProcessIsolation>
83
<IlasmRoundTripIncompatible>true</IlasmRoundTripIncompatible>
94
</PropertyGroup>
105
<ItemGroup>

src/tests/Loader/binding/tracing/BinderTracingTest.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,6 @@ public static bool RunAllTests()
8585
foreach (var method in methods)
8686
{
8787
BinderTestAttribute attribute = method.GetCustomAttribute<BinderTestAttribute>();
88-
if (attribute.Isolate && Environment.GetEnvironmentVariable("DOTNET_GCStress") != null)
89-
continue;
90-
9188
bool success = attribute.Isolate
9289
? RunTestInSeparateProcess(method)
9390
: RunSingleTest(method);

src/tests/Loader/binding/tracing/BinderTracingTest.targets

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@
44
<!-- Requires explicit Main as it implements command-line parameters for local testing purposes. -->
55
<RequiresProcessIsolation>true</RequiresProcessIsolation>
66
<ReferenceXUnitWrapperGenerator>false</ReferenceXUnitWrapperGenerator>
7+
<!-- Test creates non-collectible AssemblyLoadContext -->
8+
<UnloadabilityIncompatible>true</UnloadabilityIncompatible>
9+
<!-- Dynamic assembly loads -->
10+
<NativeAotIncompatible>true</NativeAotIncompatible>
11+
<!-- Tracing tests routinely time out with gcstress -->
12+
<GCStressIncompatible>true</GCStressIncompatible>
713
</PropertyGroup>
814
<ItemGroup>
915
<Compile Include="BinderTracingTest.cs" />

0 commit comments

Comments
 (0)