Skip to content

Commit 852fcbd

Browse files
authored
Normalize RepoRoot path to improve logs readability (#80664)
1 parent c435061 commit 852fcbd

File tree

7 files changed

+28
-17
lines changed

7 files changed

+28
-17
lines changed

eng/native/gen-buildsys.cmd

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,9 @@ if %argC% lss 4 GOTO :USAGE
1111
if %1=="/?" GOTO :USAGE
1212

1313
setlocal enabledelayedexpansion
14-
set basePath=%~dp0
15-
set __repoRoot=%~dp0..\..\
16-
:: remove quotes
17-
set "basePath=%basePath:"=%"
18-
:: remove trailing slash
19-
if %basePath:~-1%==\ set "basePath=%basePath:~0,-1%"
14+
set "__repoRoot=%~dp0..\.."
15+
:: normalize
16+
for %%i in ("%__repoRoot%") do set "__repoRoot=%%~fi"
2017

2118
set __SourceDir=%1
2219
set __IntermediatesDir=%2
@@ -53,7 +50,7 @@ if /i "%__Arch%" == "wasm" (
5350
exit /B 1
5451
)
5552

56-
set EMSDK_PATH=%__repoRoot%\src\mono\wasm\emsdk
53+
set "EMSDK_PATH=%__repoRoot%\src\mono\wasm\emsdk"
5754
)
5855
:: replace backslash with forward slash and append last slash
5956
set "EMSDK_PATH=!EMSDK_PATH:\=/!"
@@ -69,7 +66,7 @@ if /i "%__Arch%" == "wasm" (
6966
exit /B 1
7067
)
7168

72-
set WASI_SDK_PATH=%__repoRoot%src\mono\wasi\wasi-sdk
69+
set "WASI_SDK_PATH=%__repoRoot%src\mono\wasi\wasi-sdk"
7370
)
7471
:: replace backslash with forward slash and append last slash
7572
set "WASI_SDK_PATH=!WASI_SDK_PATH:\=/!"

eng/native/version/copy_version_files.cmd

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
@if not defined _echo @echo off
22
setlocal EnableDelayedExpansion EnableExtensions
33

4-
set __VersionFolder=%~dp0
5-
set __RepoRoot=%~dp0..\..\..
6-
set __artifactsObjDir=%__RepoRoot%\artifacts\obj
4+
set "__VersionFolder=%~dp0"
5+
set "__RepoRoot=%~dp0..\..\.."
6+
:: normalize
7+
for %%i in ("%__RepoRoot%") do set "__RepoRoot=%%~fi"
8+
set "__artifactsObjDir=%__RepoRoot%\artifacts\obj"
79

810
for /r "%__VersionFolder%" %%a in (*.h *.rc) do (
911
if not exist "%__artifactsObjDir%\%%~nxa" (

src/coreclr/build-runtime.cmd

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ set "__ProjectDir=%~dp0"
3232
:: remove trailing slash
3333
if %__ProjectDir:~-1%==\ set "__ProjectDir=%__ProjectDir:~0,-1%"
3434
set "__RepoRootDir=%__ProjectDir%\..\.."
35+
:: normalize
36+
for %%i in ("%__RepoRootDir%") do set "__RepoRootDir=%%~fi"
3537

3638
set "__ProjectFilesDir=%__ProjectDir%"
3739
set "__RootBinDir=%__RepoRootDir%\artifacts"

src/native/corehost/build.cmd

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@ set "__sourceDir=%~dp0"
77
:: remove trailing slash
88
if %__sourceDir:~-1%==\ set "__ProjectDir=%__sourceDir:~0,-1%"
99

10-
set __engNativeDir=%__sourceDir%\..\..\..\eng\native
10+
set "__RepoRootDir=%__sourceDir%\..\..\.."
11+
:: normalize
12+
for %%i in ("%__RepoRootDir%") do set "__RepoRootDir=%%~fi"
13+
set "__engNativeDir=%__RepoRootDir%\eng\native"
1114
set __CMakeBinDir=""
1215
set __IntermediatesDir=""
1316
set __BuildArch=x64

src/native/libs/build-native.cmd

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,14 @@ setlocal
33

44
:SetupArgs
55
:: Initialize the args that will be passed to cmake
6-
set __sourceRootDir=%~dp0
7-
set __repoRoot=%~dp0..\..\..
8-
set __engNativeDir=%__repoRoot%\eng\native
9-
set __artifactsDir=%__repoRoot%\artifacts
6+
set "__sourceRootDir=%~dp0"
7+
:: remove trailing slash
8+
if %__sourceRootDir:~-1%==\ set "__sourceRootDir=%__sourceRootDir:~0,-1%"
9+
set "__repoRoot=%__sourceRootDir%\..\..\.."
10+
:: normalize
11+
for %%i in ("%__repoRoot%") do set "__repoRoot=%%~fi"
12+
set "__engNativeDir=%__repoRoot%\eng\native"
13+
set "__artifactsDir=%__repoRoot%\artifacts"
1014
set __CMakeBinDir=""
1115
set __IntermediatesDir=""
1216
set __BuildArch=x64

src/tests/build.cmd

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ set "__ProjectDir=%~dp0"
1111
:: remove trailing slash
1212
if %__ProjectDir:~-1%==\ set "__ProjectDir=%__ProjectDir:~0,-1%"
1313
set "__RepoRootDir=%__ProjectDir%\..\.."
14-
for %%i in ("%__RepoRootDir%") do SET "__RepoRootDir=%%~fi"
14+
:: normalize
15+
for %%i in ("%__RepoRootDir%") do set "__RepoRootDir=%%~fi"
1516

1617
set "__TestDir=%__RepoRootDir%\src\tests"
1718

src/tests/run.cmd

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ set __TargetOS=windows
1212

1313
set "__ProjectDir=%~dp0"
1414
set "__RepoRootDir=%~dp0..\.."
15+
:: normalize
16+
for %%i in ("%__RepoRootDir%") do set "__RepoRootDir=%%~fi"
1517
:: remove trailing slash
1618
if %__ProjectDir:~-1%==\ set "__ProjectDir=%__ProjectDir:~0,-1%"
1719
set "__ProjectFilesDir=%__ProjectDir%"

0 commit comments

Comments
 (0)