Disable some PerformanceCounter tests on more platforms (#64633)

sbomer · web-flow · commit 6fc2548944f3 · 2022-02-01T12:37:48.000-08:00
These tests were disabled in #61101 due to random failures like #60933. We are continuing to see these failures on x86 as well.
diff --git a/src/libraries/System.Diagnostics.PerformanceCounter/tests/PerformanceCounterCategoryTests.cs b/src/libraries/System.Diagnostics.PerformanceCounter/tests/PerformanceCounterCategoryTests.cs
@@ -78,7 +78,7 @@ public static void PerformanceCounterCategory_GetCounterHelp_Invalid()
         }
 
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndCanWriteAndReadNetPerfCounters))]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.Is64BitProcess))]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows))]
         public static void PerformanceCounterCategory_CategoryType_MultiInstance()
         {
             string categoryName = nameof(PerformanceCounterCategory_CategoryType_MultiInstance) + "_Category";
@@ -267,7 +267,7 @@ public static void PerformanceCounterCategory_InstanceExists_Invalid()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.Is64BitProcess))]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows))]
         public static void PerformanceCounterCategory_InstanceExists_Static()
         {
             PerformanceCounterCategory pcc = Helpers.RetryOnAllPlatforms(() => new PerformanceCounterCategory("Processor"));
@@ -291,7 +291,7 @@ public static void PerformanceCounterCategory_InstanceExists_StaticInvalid()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.Is64BitProcess))]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows))]
         public static void PerformanceCounterCategory_ReadCategory()
         {
             PerformanceCounterCategory pcc = Helpers.RetryOnAllPlatforms(() => new PerformanceCounterCategory("Processor"));
diff --git a/src/libraries/System.Diagnostics.PerformanceCounter/tests/PerformanceCounterTests.cs b/src/libraries/System.Diagnostics.PerformanceCounter/tests/PerformanceCounterTests.cs
@@ -39,7 +39,7 @@ public static void PerformanceCounter_CreateCounter_Count0()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.Is64BitProcess))]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows))]
         public static void PerformanceCounter_CreateCounter_ProcessorCounter()
         {
             using (PerformanceCounter counterSample = new PerformanceCounter("Processor", "Interrupts/sec", "0", "."))
@@ -188,7 +188,7 @@ public static void PerformanceCounter_BeginInit_ProcessorCounter()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.Is64BitProcess))]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows))]
         public static void PerformanceCounter_BeginInitEndInit_ProcessorCounter()
         {
             using (PerformanceCounter counterSample = new PerformanceCounter("Processor", "Interrupts/sec", "0", "."))
@@ -270,7 +270,7 @@ public static void PerformanceCounter_Increment_IncrementReadOnly()
         }
 
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndCanWriteAndReadNetPerfCounters))]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.Is64BitProcess))]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows))]
         public static void PerformanceCounter_Decrement_DecrementReadOnly()
         {
             string categoryName = nameof(PerformanceCounter_Decrement_DecrementReadOnly) + "_Category";

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ public static void PerformanceCounterCategory_GetCounterHelp_Invalid()`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`[ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndCanWriteAndReadNetPerfCounters))]`
`81`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.Is64BitProcess))]`
	`81`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows))]`
`82`	`82`	`public static void PerformanceCounterCategory_CategoryType_MultiInstance()`
`83`	`83`	`{`
`84`	`84`	`string categoryName = nameof(PerformanceCounterCategory_CategoryType_MultiInstance) + "_Category";`
`@@ -267,7 +267,7 @@ public static void PerformanceCounterCategory_InstanceExists_Invalid()`
`267`	`267`	`}`
`268`	`268`
`269`	`269`	`[Fact]`
`270`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.Is64BitProcess))]`
	`270`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows))]`
`271`	`271`	`public static void PerformanceCounterCategory_InstanceExists_Static()`
`272`	`272`	`{`
`273`	`273`	`PerformanceCounterCategory pcc = Helpers.RetryOnAllPlatforms(() => new PerformanceCounterCategory("Processor"));`
`@@ -291,7 +291,7 @@ public static void PerformanceCounterCategory_InstanceExists_StaticInvalid()`
`291`	`291`	`}`
`292`	`292`
`293`	`293`	`[Fact]`
`294`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.Is64BitProcess))]`
	`294`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows))]`
`295`	`295`	`public static void PerformanceCounterCategory_ReadCategory()`
`296`	`296`	`{`
`297`	`297`	`PerformanceCounterCategory pcc = Helpers.RetryOnAllPlatforms(() => new PerformanceCounterCategory("Processor"));`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public static void PerformanceCounter_CreateCounter_Count0()`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`[Fact]`
`42`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.Is64BitProcess))]`
	`42`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows))]`
`43`	`43`	`public static void PerformanceCounter_CreateCounter_ProcessorCounter()`
`44`	`44`	`{`
`45`	`45`	`using (PerformanceCounter counterSample = new PerformanceCounter("Processor", "Interrupts/sec", "0", "."))`
`@@ -188,7 +188,7 @@ public static void PerformanceCounter_BeginInit_ProcessorCounter()`
`188`	`188`	`}`
`189`	`189`
`190`	`190`	`[Fact]`
`191`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.Is64BitProcess))]`
	`191`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows))]`
`192`	`192`	`public static void PerformanceCounter_BeginInitEndInit_ProcessorCounter()`
`193`	`193`	`{`
`194`	`194`	`using (PerformanceCounter counterSample = new PerformanceCounter("Processor", "Interrupts/sec", "0", "."))`
`@@ -270,7 +270,7 @@ public static void PerformanceCounter_Increment_IncrementReadOnly()`
`270`	`270`	`}`
`271`	`271`
`272`	`272`	`[ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndCanWriteAndReadNetPerfCounters))]`
`273`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.Is64BitProcess))]`
	`273`	`+ [ActiveIssue("https://github.com/dotnet/runtime/issues/60933", typeof(PlatformDetection), nameof(PlatformDetection.IsWindows))]`
`274`	`274`	`public static void PerformanceCounter_Decrement_DecrementReadOnly()`
`275`	`275`	`{`
`276`	`276`	`string categoryName = nameof(PerformanceCounter_Decrement_DecrementReadOnly) + "_Category";`