Skip to content

Commit 6387a2d

Browse files
authored
Run illink before ApiCompat (#66706)
* Run illink before ApiCompat and GenAPI As observed in #66634 (comment), illink currently runs after APICompat. This happens because nuget imports the ApiCompat targets earlier than the illink.targets is imported. * Update illink.targets * Use ApiCompatDependsOn
1 parent b42adad commit 6387a2d

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

eng/illink.targets

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,10 @@
11
<Project>
22
<PropertyGroup>
33
<IsTrimmable Condition="'$(IsTrimmable)' == ''">true</IsTrimmable>
4-
<PrepareResourcesDependsOn>
5-
_EmbedILLinkXmls;
6-
$(PrepareResourcesDependsOn)
7-
</PrepareResourcesDependsOn>
8-
</PropertyGroup>
9-
10-
<PropertyGroup>
11-
<TargetsTriggeredByCompilation Condition="'$(DesignTimeBuild)' != 'true'">
12-
$(TargetsTriggeredByCompilation);
13-
ILLinkTrimAssembly
14-
</TargetsTriggeredByCompilation>
4+
<PrepareResourcesDependsOn>_EmbedILLinkXmls;$(PrepareResourcesDependsOn)</PrepareResourcesDependsOn>
5+
<TargetsTriggeredByCompilation Condition="'$(DesignTimeBuild)' != 'true'">$(TargetsTriggeredByCompilation);ILLinkTrimAssembly</TargetsTriggeredByCompilation>
6+
<!-- ApiCompat should perform compatibility checks on the trimmed assemblies. -->
7+
<ApiCompatDependsOn>$(ApiCompatDependsOn);ILLinkTrimAssembly</ApiCompatDependsOn>
158
</PropertyGroup>
169

1710
<!-- Inputs and outputs of ILLinkTrimAssembly -->

0 commit comments

Comments
 (0)