Skip to content

Commit 487c8fc

Browse files
authored
[wasm] Revert back to using latest stable versions of chrome for testing (#80135)
* [wasm] Revert back to using latest stable versions of chrome for testing * [wasm] widen the search area for chrome snapshots. They seem to be less frequent for windows builds.
1 parent d8c81ce commit 487c8fc

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

eng/testing/ProvisioningVersions.props

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
4040
Refer to `GetChromeVersions` task in `src/tasks` to see how we find
4141
these snapshot urls.
42-
-->
42+
4343
<PropertyGroup Label="Use specific version of chrome" Condition="$([MSBuild]::IsOSPlatform('linux'))">
4444
<ChromeVersion>107.0.5304.110</ChromeVersion>
4545
<ChromeRevision>1047731</ChromeRevision>
@@ -51,6 +51,8 @@
5151
<_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/1047737</_ChromeBaseSnapshotUrl>
5252
</PropertyGroup>
5353
54+
-->
55+
5456
<PropertyGroup Condition="'$(BrowserHost)' != 'windows'">
5557
<FirefoxRevision>108.0.1</FirefoxRevision>
5658
<FirefoxUrl>https://ftp.mozilla.org/pub/firefox/releases/$(FirefoxRevision)/linux-x86_64/en-US/firefox-$(FirefoxRevision).tar.bz2</FirefoxUrl>

src/tasks/WasmBuildTasks/GetChromeVersions.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public class GetChromeVersions : MBU.Task
2222
private const string s_allJsonUrl = "http://omahaproxy.appspot.com/all.json";
2323
private const string s_snapshotBaseUrl = $"https://storage.googleapis.com/chromium-browser-snapshots";
2424
private const int s_versionCheckThresholdDays = 3;
25-
private const int s_numBranchPositionsToTry = 30;
25+
private const int s_numBranchPositionsToTry = 50;
2626
private static readonly HttpClient s_httpClient = new();
2727

2828
public string Channel { get; set; } = "stable";
@@ -103,7 +103,8 @@ private async Task<string> GetChromeUrlsAsync(ChromeVersionSpec version)
103103

104104
throw new LogAsErrorException($"Could not find a chrome snapshot folder under {baseUrl}, " +
105105
$"for branch positions {version.branch_base_position} to " +
106-
$"{branchPosition}, for version {version.version}.");
106+
$"{branchPosition}, for version {version.version}. " +
107+
"A fixed version+url can be set in eng/testing/ProvisioningVersions.props .");
107108
}
108109

109110
private async Task<ChromeVersionSpec> GetChromeVersionAsync()

0 commit comments

Comments
 (0)