Fix NonCryptoHashTestDriver.AssertEqualHashNumber for big endian (#79135)

stephentoub · web-flow · commit 47e26b2ed863 · 2022-12-02T13:08:23.000+01:00
Fix #78075 (comment)
diff --git a/src/libraries/System.IO.Hashing/tests/NonCryptoHashTestDriver.cs b/src/libraries/System.IO.Hashing/tests/NonCryptoHashTestDriver.cs
@@ -297,7 +297,7 @@ private void VerifyEmptyResult(ReadOnlySpan<byte> result)
 
         protected static void AssertEqualHashNumber(string hex, uint hash, bool littleEndian = false)
         {
-            if (littleEndian == BitConverter.IsLittleEndian)
+            if (littleEndian)
             {
                 hash = BinaryPrimitives.ReverseEndianness(hash);
             }
@@ -306,7 +306,7 @@ protected static void AssertEqualHashNumber(string hex, uint hash, bool littleEn
 
         protected static void AssertEqualHashNumber(string hex, ulong hash, bool littleEndian = false)
         {
-            if (littleEndian == BitConverter.IsLittleEndian)
+            if (littleEndian)
             {
                 hash = BinaryPrimitives.ReverseEndianness(hash);
             }

Original file line number	Diff line number	Diff line change
`@@ -297,7 +297,7 @@ private void VerifyEmptyResult(ReadOnlySpan<byte> result)`
`297`	`297`
`298`	`298`	`protected static void AssertEqualHashNumber(string hex, uint hash, bool littleEndian = false)`
`299`	`299`	`{`
`300`		`- if (littleEndian == BitConverter.IsLittleEndian)`
	`300`	`+ if (littleEndian)`
`301`	`301`	`{`
`302`	`302`	`hash = BinaryPrimitives.ReverseEndianness(hash);`
`303`	`303`	`}`
`@@ -306,7 +306,7 @@ protected static void AssertEqualHashNumber(string hex, uint hash, bool littleEn`
`306`	`306`
`307`	`307`	`protected static void AssertEqualHashNumber(string hex, ulong hash, bool littleEndian = false)`
`308`	`308`	`{`
`309`		`- if (littleEndian == BitConverter.IsLittleEndian)`
	`309`	`+ if (littleEndian)`
`310`	`310`	`{`
`311`	`311`	`hash = BinaryPrimitives.ReverseEndianness(hash);`
`312`	`312`	`}`