Skip to content

Commit 3853cb8

Browse files
wfurtstephentoub
andauthored
use PlatformSpecific attribute to supress platform specific Quic tests (#82933)
* use PlatformSpecific attribute to supress platform specific Quic tests * Update src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs Co-authored-by: Stephen Toub <[email protected]> --------- Co-authored-by: Stephen Toub <[email protected]>
1 parent f604caf commit 3853cb8

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,17 @@ public void UnsupportedPlatforms_ThrowsPlatformNotSupportedException()
2323

2424
[ActiveIssue("https://github.com/dotnet/runtime/issues/73290", typeof(PlatformDetection), nameof(PlatformDetection.IsSingleFile))]
2525
[ActiveIssue("https://github.com/dotnet/runtime/issues/82885", typeof(PlatformDetection), nameof(PlatformDetection.IsArm64Process))]
26-
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.SupportsTls13))]
26+
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.SupportsTls13))]
27+
[PlatformSpecific(TestPlatforms.Windows)]
2728
public void SupportedWindowsPlatforms_IsSupportedIsTrue()
2829
{
2930
Assert.True(QuicListener.IsSupported);
3031
Assert.True(QuicConnection.IsSupported);
3132
}
3233

3334
[ActiveIssue("https://github.com/dotnet/runtime/issues/81901", typeof(PlatformDetection), nameof(PlatformDetection.IsAlpine314), nameof(PlatformDetection.IsInContainer))]
34-
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsLinux))]
35+
[Fact]
36+
[PlatformSpecific(TestPlatforms.Linux)]
3537
public async Task SupportedLinuxPlatformsWithMsQuic_IsSupportedIsTrue()
3638
{
3739
using Process find = new Process();
@@ -61,7 +63,8 @@ public async Task SupportedLinuxPlatformsWithMsQuic_IsSupportedIsTrue()
6163
[ActiveIssue("https://github.com/dotnet/runtime/issues/82154", typeof(PlatformDetection), nameof(PlatformDetection.IsRaspbian10), nameof(PlatformDetection.IsArmv6Process), nameof(PlatformDetection.IsInContainer))]
6264
[ActiveIssue("https://github.com/dotnet/runtime/issues/82154", typeof(PlatformDetection), nameof(PlatformDetection.IsUbuntu2004), nameof(PlatformDetection.IsPpc64leProcess))]
6365
[ActiveIssue("https://github.com/dotnet/runtime/issues/82154", typeof(PlatformDetection), nameof(PlatformDetection.IsUbuntu2004), nameof(PlatformDetection.IsS390xProcess))]
64-
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsLinux), nameof(PlatformDetection.IsInHelix))]
66+
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsInHelix))]
67+
[PlatformSpecific(TestPlatforms.Linux)]
6568
public void SupportedLinuxPlatforms_IsSupportedIsTrue()
6669
{
6770
_output.WriteLine($"Running on {PlatformDetection.GetDistroVersionString()}");

0 commit comments

Comments
 (0)