Fix CA2021 in MethodBodyScanner (#81200)

MichalStrehovsky · web-flow · commit 301cb81f7707 · 2023-01-26T18:30:29.000+09:00
diff --git a/src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/MethodBodyScanner.cs b/src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/MethodBodyScanner.cs
@@ -319,7 +319,7 @@ public virtual void InterproceduralScan(MethodIL startingMethodBody)
             // are the same set of methods that we discovered and scanned above.
             if (_annotations.CompilerGeneratedState.TryGetCompilerGeneratedCalleesForUserMethod(startingMethod, out List<TypeSystemEntity>? compilerGeneratedCallees))
             {
-                var calleeMethods = compilerGeneratedCallees.OfType<MethodDefinition>();
+                var calleeMethods = compilerGeneratedCallees.OfType<MethodDesc>();
                 // https://github.com/dotnet/linker/issues/2845
                 // Disabled asserts due to a bug
                 // Debug.Assert (interproceduralState.Count == 1 + calleeMethods.Count ());

Original file line number	Diff line number	Diff line change
`@@ -319,7 +319,7 @@ public virtual void InterproceduralScan(MethodIL startingMethodBody)`
`319`	`319`	`// are the same set of methods that we discovered and scanned above.`
`320`	`320`	`if (_annotations.CompilerGeneratedState.TryGetCompilerGeneratedCalleesForUserMethod(startingMethod, out List<TypeSystemEntity>? compilerGeneratedCallees))`
`321`	`321`	`{`
`322`		`- var calleeMethods = compilerGeneratedCallees.OfType<MethodDefinition>();`
	`322`	`+ var calleeMethods = compilerGeneratedCallees.OfType<MethodDesc>();`
`323`	`323`	`// https://github.com/dotnet/linker/issues/2845`
`324`	`324`	`// Disabled asserts due to a bug`
`325`	`325`	`// Debug.Assert (interproceduralState.Count == 1 + calleeMethods.Count ());`