Skip to content

Commit 21f1a2b

Browse files
authored
Reenable System.Runtime.Serialization.Xml.Tests (#68921)
* Reenable `System.Runtime.Serialization.Xml.Tests` This was disabled due to #59926, which was then tracked by #61061 . The stack overflow is due to one specific test though, and the rest of the tests can be enabled if we skip this one - `DCS_DeeplyLinkedData`. * Disable the test with `SkipOnPlatform` instead, for wasm, as it is .. unlikely to be fixed (- vargaz).
1 parent f730657 commit 21f1a2b

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

src/libraries/System.Runtime.Serialization.Xml/tests/DataContractSerializer.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4256,6 +4256,7 @@ public static void DCS_TypeWithPrimitiveKnownTypes()
42564256
}
42574257

42584258
[ActiveIssue("https://github.com/dotnet/runtime/issues/1417", TestPlatforms.OSX)]
4259+
[SkipOnPlatform(TestPlatforms.Browser, "Causes a stack overflow")]
42594260
[Fact]
42604261
public static void DCS_DeeplyLinkedData()
42614262
{

src/libraries/tests.proj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -333,8 +333,6 @@
333333

334334
<!-- Aggressive Trimming related failures -->
335335
<ItemGroup Condition="('$(TargetOS)' != 'Browser' and '$(RunAOTCompilation)' == 'true' and '$(MonoForceInterpreter)' != 'true') or ('$(TargetOS)' == 'Browser' and '$(BuildAOTTestsOnHelix)' == 'true' and '$(RunDisabledWasmTests)' != 'true')">
336-
<!-- Issue: https://github.com/dotnet/runtime/issues/59926 -->
337-
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.Serialization.Xml\tests\System.Runtime.Serialization.Xml.Tests.csproj" />
338336
</ItemGroup>
339337

340338
<ItemGroup Condition="('$(TargetOS)' != 'Browser' and '$(RunAOTCompilation)' == 'true' and '$(MonoForceInterpreter)' != 'true') or ('$(TargetOS)' == 'Browser' and '$(BuildAOTTestsOnHelix)' == 'true' and '$(RunDisabledWasmTests)' != 'true') or ('$(TargetOS)' == 'iOS' and '$(BuildTestsOnHelix)' == 'true')">

0 commit comments

Comments
 (0)