Fix most violations of new CA1859 (#80335)

* Fix most violations of new CA1859

The analyzer recommends replacing uses of types with other types that could reduce overheads (e.g. `List<T>` instead of `IList<T>`).  This fixes most of the violations we currently have of the rule, but it doesn't enable it yet because there are too many false positives; fixes for those are in-flight.  Some of these replacements won't help with perf (e.g. using `ArgumentException` instead of `Exception` as the return type of a throw helper create method), but there's little harm to them, and some of them do avoid overheads like allocation (e.g. foreach'ing something typed as `Dictionary<>` instead of `IDictionary<>` will avoid an enumerator allocation, accessing `Count` on a `List<T>` instead of `IList<T>` will avoid an interface dispatch, etc.)

* Fix mistaken replacement

Author: stephentoub

src/coreclr/System.Private.CoreLib/src/System/Reflection/Assembly.CoreCLR.cs

@@ -83,7 +83,7 @@ public static Assembly GetCallingAssembly()
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "AssemblyNative_GetEntryAssembly")]
         private static partial void GetEntryAssemblyNative(ObjectHandleOnStack retAssembly);
 
-        private static Assembly? GetEntryAssemblyInternal()
+        private static RuntimeAssembly? GetEntryAssemblyInternal()
         {
             RuntimeAssembly? entryAssembly = null;
             GetEntryAssemblyNative(ObjectHandleOnStack.Create(ref entryAssembly));

src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/DynamicILGenerator.cs

@@ -403,7 +403,7 @@ public override void EndScope()
             throw new NotSupportedException(SR.InvalidOperation_NotAllowedInDynamicMethod);
         }
 
-        private int GetMemberRefToken(MethodBase methodInfo, Type[]? optionalParameterTypes)
+        private int GetMemberRefToken(MethodInfo methodInfo, Type[]? optionalParameterTypes)
         {
             Type[]? parameterTypes;
             Type[][]? requiredCustomModifiers;

src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeCustomAttributeData.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.Collections.Generic;
+using System.Collections.ObjectModel;
 using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
 using System.Runtime.CompilerServices;
@@ -92,7 +93,7 @@ internal static IList<CustomAttributeData> GetCustomAttributesInternal(RuntimePa
             return pcas.Count > 0 ? GetCombinedList(cad, ref pcas) : cad;
         }
 
-        private static IList<CustomAttributeData> GetCombinedList(IList<CustomAttributeData> customAttributes, ref RuntimeType.ListBuilder<Attribute> pseudoAttributes)
+        private static ReadOnlyCollection<CustomAttributeData> GetCombinedList(IList<CustomAttributeData> customAttributes, ref RuntimeType.ListBuilder<Attribute> pseudoAttributes)
         {
             Debug.Assert(pseudoAttributes.Count != 0);
 

src/coreclr/System.Private.CoreLib/src/System/Runtime/Loader/AssemblyLoadContext.CoreCLR.cs

@@ -54,7 +54,7 @@ public partial class AssemblyLoadContext
         internal static partial bool TraceSatelliteSubdirectoryPathProbed(string filePath, int hResult);
 
         [RequiresUnreferencedCode("Types and members the loaded assembly depends on might be removed")]
-        private Assembly InternalLoadFromPath(string? assemblyPath, string? nativeImagePath)
+        private RuntimeAssembly InternalLoadFromPath(string? assemblyPath, string? nativeImagePath)
         {
             RuntimeAssembly? loadedAssembly = null;
             LoadFromPath(_nativeAssemblyLoadContext, assemblyPath, nativeImagePath, ObjectHandleOnStack.Create(ref loadedAssembly));

src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs

@@ -1995,7 +1995,7 @@ internal static FieldInfo GetFieldInfo(RuntimeType? reflectedType, IRuntimeField
         }
 
         // Called internally
-        private static PropertyInfo GetPropertyInfo(RuntimeType reflectedType, int tkProperty)
+        private static RuntimePropertyInfo GetPropertyInfo(RuntimeType reflectedType, int tkProperty)
         {
             RuntimePropertyInfo property;
             RuntimePropertyInfo[] candidates =
@@ -3166,7 +3166,7 @@ public override MemberInfo GetMemberWithSameMetadataDefinitionAs(MemberInfo memb
             throw CreateGetMemberWithSameMetadataDefinitionAsNotFoundException(member);
         }
 
-        private static MemberInfo? GetMethodWithSameMetadataDefinitionAs(RuntimeType runtimeType, MemberInfo method)
+        private static RuntimeMethodInfo? GetMethodWithSameMetadataDefinitionAs(RuntimeType runtimeType, MemberInfo method)
         {
             RuntimeMethodInfo[] cache = runtimeType.Cache.GetMethodList(MemberListType.CaseSensitive, method.Name);
 
@@ -3182,7 +3182,7 @@ public override MemberInfo GetMemberWithSameMetadataDefinitionAs(MemberInfo memb
             return null;
         }
 
-        private static MemberInfo? GetConstructorWithSameMetadataDefinitionAs(RuntimeType runtimeType, MemberInfo constructor)
+        private static RuntimeConstructorInfo? GetConstructorWithSameMetadataDefinitionAs(RuntimeType runtimeType, MemberInfo constructor)
         {
             RuntimeConstructorInfo[] cache = runtimeType.Cache.GetConstructorList(MemberListType.CaseSensitive, constructor.Name);
 
@@ -3198,7 +3198,7 @@ public override MemberInfo GetMemberWithSameMetadataDefinitionAs(MemberInfo memb
             return null;
         }
 
-        private static MemberInfo? GetPropertyWithSameMetadataDefinitionAs(RuntimeType runtimeType, MemberInfo property)
+        private static RuntimePropertyInfo? GetPropertyWithSameMetadataDefinitionAs(RuntimeType runtimeType, MemberInfo property)
         {
             RuntimePropertyInfo[] cache = runtimeType.Cache.GetPropertyList(MemberListType.CaseSensitive, property.Name);
 
@@ -3214,7 +3214,7 @@ public override MemberInfo GetMemberWithSameMetadataDefinitionAs(MemberInfo memb
             return null;
         }
 
-        private static MemberInfo? GetFieldWithSameMetadataDefinitionAs(RuntimeType runtimeType, MemberInfo field)
+        private static RuntimeFieldInfo? GetFieldWithSameMetadataDefinitionAs(RuntimeType runtimeType, MemberInfo field)
         {
             RuntimeFieldInfo[] cache = runtimeType.Cache.GetFieldList(MemberListType.CaseSensitive, field.Name);
 
@@ -3230,7 +3230,7 @@ public override MemberInfo GetMemberWithSameMetadataDefinitionAs(MemberInfo memb
             return null;
         }
 
-        private static MemberInfo? GetEventWithSameMetadataDefinitionAs(RuntimeType runtimeType, MemberInfo eventInfo)
+        private static RuntimeEventInfo? GetEventWithSameMetadataDefinitionAs(RuntimeType runtimeType, MemberInfo eventInfo)
         {
             RuntimeEventInfo[] cache = runtimeType.Cache.GetEventList(MemberListType.CaseSensitive, eventInfo.Name);
 
@@ -3246,7 +3246,7 @@ public override MemberInfo GetMemberWithSameMetadataDefinitionAs(MemberInfo memb
             return null;
         }
 
-        private static MemberInfo? GetNestedTypeWithSameMetadataDefinitionAs(RuntimeType runtimeType, MemberInfo nestedType)
+        private static RuntimeType? GetNestedTypeWithSameMetadataDefinitionAs(RuntimeType runtimeType, MemberInfo nestedType)
         {
             RuntimeType[] cache = runtimeType.Cache.GetNestedTypeList(MemberListType.CaseSensitive, nestedType.Name);
 

src/libraries/Common/src/Interop/Windows/BCrypt/Cng.cs

@@ -5,11 +5,13 @@
 using System.Text;
 using System.Diagnostics;
 using System.Runtime.InteropServices;
+using System.Security.Cryptography;
 
 using Internal.Cryptography;
+using Microsoft.Win32.SafeHandles;
+
 using static Interop;
 using static Interop.BCrypt;
-using Microsoft.Win32.SafeHandles;
 
 namespace Internal.NativeCrypto
 {
@@ -112,7 +114,7 @@ public static void SetEffectiveKeyLength(this SafeAlgorithmHandle hAlg, int effe
             }
         }
 
-        private static Exception CreateCryptographicException(NTSTATUS ntStatus)
+        private static CryptographicException CreateCryptographicException(NTSTATUS ntStatus)
         {
             int hr = ((int)ntStatus) | 0x01000000;
             return hr.ToCryptographicException();

src/libraries/Common/src/System/Security/Cryptography/RSAAndroid.cs

@@ -792,7 +792,7 @@ internal SafeRsaHandle DuplicateKeyHandle()
                 return _key.Value.DuplicateHandle();
             }
 
-            private static Exception PaddingModeNotSupported() =>
+            private static CryptographicException PaddingModeNotSupported() =>
                 new CryptographicException(SR.Cryptography_InvalidPaddingMode);
         }
     }

src/libraries/Common/src/System/Security/Cryptography/RSAOpenSsl.cs

@@ -902,7 +902,7 @@ private static void ValidatePadding(RSASignaturePadding padding)
 
         static partial void ThrowIfNotSupported();
 
-        private static Exception PaddingModeNotSupported() =>
+        private static CryptographicException PaddingModeNotSupported() =>
             new CryptographicException(SR.Cryptography_InvalidPaddingMode);
     }
 }

src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs

@@ -691,7 +691,7 @@ private static Array BindArray(Type type, IEnumerable? source, IConfiguration co
                 elementType = type.GetGenericArguments()[0];
             }
 
-            IList list = new List<object?>();
+            var list = new List<object?>();
 
             if (source != null)
             {
@@ -727,7 +727,7 @@ private static Array BindArray(Type type, IEnumerable? source, IConfiguration co
             }
 
             Array result = Array.CreateInstance(elementType, list.Count);
-            list.CopyTo(result, 0);
+            ((IList)list).CopyTo(result, 0);
             return result;
         }
 
@@ -976,7 +976,7 @@ private static List<PropertyInfo> GetAllProperties([DynamicallyAccessedMembers(D
             return propertyBindingPoint.Value;
         }
 
-        private static string GetPropertyName(MemberInfo property)
+        private static string GetPropertyName(PropertyInfo property)
         {
             ThrowHelper.ThrowIfNull(property);
 

src/libraries/Microsoft.Extensions.Configuration.Json/src/JsonConfigurationFileParser.cs

@@ -19,7 +19,7 @@ private JsonConfigurationFileParser() { }
         public static IDictionary<string, string?> Parse(Stream input)
             => new JsonConfigurationFileParser().ParseStream(input);
 
-        private IDictionary<string, string?> ParseStream(Stream input)
+        private Dictionary<string, string?> ParseStream(Stream input)
         {
             var jsonDocumentOptions = new JsonDocumentOptions
             {

src/libraries/Microsoft.Extensions.Configuration.Xml/src/XmlStreamConfigurationProvider.cs

@@ -245,7 +245,7 @@ private static void ReadAttributes(XmlReader reader, XmlConfigurationElement ele
             return name;
         }
 
-        private static IDictionary<string, string?> ProvideConfiguration(XmlConfigurationElement? root)
+        private static Dictionary<string, string?> ProvideConfiguration(XmlConfigurationElement? root)
         {
             Dictionary<string, string?> configuration = new(StringComparer.OrdinalIgnoreCase);
 

src/libraries/Microsoft.Extensions.Configuration/src/ConfigurationRoot.cs

@@ -14,7 +14,7 @@ namespace Microsoft.Extensions.Configuration
     public class ConfigurationRoot : IConfigurationRoot, IDisposable
     {
         private readonly IList<IConfigurationProvider> _providers;
-        private readonly IList<IDisposable> _changeTokenRegistrations;
+        private readonly List<IDisposable> _changeTokenRegistrations;
         private ConfigurationReloadToken _changeToken = new ConfigurationReloadToken();
 
         /// <summary>

src/libraries/Microsoft.Extensions.DependencyInjection.Abstractions/src/ActivatorUtilities.cs

@@ -222,7 +222,7 @@ private static MethodInfo GetMethodInfo<T>(Expression<T> expr)
             return service;
         }
 
-        private static Expression BuildFactoryExpression(
+        private static NewExpression BuildFactoryExpression(
             ConstructorInfo constructor,
             int?[] parameterMap,
             Expression serviceProvider,

src/libraries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/CallSiteFactory.cs

@@ -398,7 +398,7 @@ private static CallSiteResultCacheLocation GetCommonCacheLocation(CallSiteResult
             return null;
         }
 
-        private ServiceCallSite CreateConstructorCallSite(
+        private ConstructorCallSite CreateConstructorCallSite(
             ResultCache lifetime,
             Type serviceType,
             [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)] Type implementationType,

src/libraries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/Expressions/ExpressionResolverBuilder.cs

@@ -201,7 +201,7 @@ protected override Expression VisitScopeCache(ServiceCallSite callSite, object?
         }
 
         // Move off the main stack
-        private Expression BuildScopedExpression(ServiceCallSite callSite)
+        private ConditionalExpression BuildScopedExpression(ServiceCallSite callSite)
         {
             ConstantExpression callSiteExpression = Expression.Constant(
                 callSite,

src/libraries/Microsoft.Extensions.DependencyModel/src/CompilationLibrary.cs

@@ -71,7 +71,7 @@ public IEnumerable<string> ResolveReferencePaths(params ICompilationAssemblyReso
             return ResolveReferencePaths(DefaultResolver, assemblies);
         }
 
-        private IEnumerable<string> ResolveReferencePaths(ICompilationAssemblyResolver resolver, List<string> assemblies)
+        private List<string> ResolveReferencePaths(ICompilationAssemblyResolver resolver, List<string> assemblies)
         {
             if (!resolver.TryResolveAssemblyPaths(this, assemblies))
             {

src/libraries/Microsoft.Extensions.DependencyModel/src/DependencyContextJsonReader.cs

@@ -17,7 +17,7 @@ public class DependencyContextJsonReader : IDependencyContextReader
         private const int UnseekableStreamInitialRentSize = 4096;
         private static ReadOnlySpan<byte> Utf8Bom => new byte[] { 0xEF, 0xBB, 0xBF };
 
-        private readonly IDictionary<string, string> _stringPool = new Dictionary<string, string>();
+        private readonly Dictionary<string, string> _stringPool = new Dictionary<string, string>();
 
         public DependencyContext Read(Stream stream)
         {
@@ -448,7 +448,7 @@ private TargetLibrary ReadTargetLibrary(ref Utf8JsonReader reader, string target
             };
         }
 
-        private IEnumerable<Dependency> ReadTargetLibraryDependencies(ref Utf8JsonReader reader)
+        private List<Dependency> ReadTargetLibraryDependencies(ref Utf8JsonReader reader)
         {
             var dependencies = new List<Dependency>();
 

src/libraries/Microsoft.Extensions.DependencyModel/src/Utf8JsonReaderExtensions.cs

@@ -132,7 +132,7 @@ public static bool ReadAsBoolean(this ref Utf8JsonReader reader, bool defaultVal
             return reader.GetBoolean();
         }
 
-        private static Exception CreateUnexpectedException(ref Utf8JsonReader reader, string expected)
+        private static FormatException CreateUnexpectedException(ref Utf8JsonReader reader, string expected)
         {
             // Replace with public API once https://github.com/dotnet/runtime/issues/28482 is fixed
             object boxedState = reader.CurrentState;

src/libraries/Microsoft.Extensions.FileSystemGlobbing/src/Internal/Patterns/PatternBuilder.cs

@@ -41,9 +41,9 @@ public IPattern Build(string pattern)
             var allSegments = new List<IPathSegment>();
             bool isParentSegmentLegal = true;
 
-            IList<IPathSegment>? segmentsPatternStartsWith = null;
-            IList<IList<IPathSegment>>? segmentsPatternContains = null;
-            IList<IPathSegment>? segmentsPatternEndsWith = null;
+            List<IPathSegment>? segmentsPatternStartsWith = null;
+            List<IList<IPathSegment>>? segmentsPatternContains = null;
+            List<IPathSegment>? segmentsPatternEndsWith = null;
 
             int endPattern = pattern.Length;
             for (int scanPattern = 0; scanPattern < endPattern;)

src/libraries/Microsoft.Extensions.FileSystemGlobbing/src/Matcher.cs

@@ -96,8 +96,8 @@ namespace Microsoft.Extensions.FileSystemGlobbing
     /// </remarks>
     public class Matcher
     {
-        private readonly IList<IPattern> _includePatterns = new List<IPattern>();
-        private readonly IList<IPattern> _excludePatterns = new List<IPattern>();
+        private readonly List<IPattern> _includePatterns = new List<IPattern>();
+        private readonly List<IPattern> _excludePatterns = new List<IPattern>();
         private readonly PatternBuilder _builder;
         private readonly StringComparison _comparison;
 

src/libraries/Microsoft.Extensions.Hosting/src/Internal/Host.cs

@@ -125,7 +125,7 @@ public async Task StopAsync(CancellationToken cancellationToken = default)
                 // Trigger IHostApplicationLifetime.ApplicationStopping
                 _applicationLifetime.StopApplication();
 
-                IList<Exception> exceptions = new List<Exception>();
+                var exceptions = new List<Exception>();
                 if (_hostedServices != null) // Started?
                 {
                     foreach (IHostedService hostedService in _hostedServices.Reverse())

src/libraries/Microsoft.Extensions.Logging.EventLog/src/EventLogSettings.cs

@@ -40,7 +40,7 @@ internal IEventLog EventLog
             set => _eventLog = value;
         }
 
-        private IEventLog CreateDefaultEventLog()
+        private WindowsEventLog CreateDefaultEventLog()
         {
             string logName = string.IsNullOrEmpty(LogName) ? "Application" : LogName;
             string machineName = string.IsNullOrEmpty(MachineName) ? "." : MachineName;

src/libraries/Microsoft.NETCore.Platforms/src/GenerateRuntimeGraph.cs

@@ -292,7 +292,7 @@ private RuntimeGraph SafeMerge(RuntimeGraph existingGraph, RuntimeGroup runtimeG
             return RuntimeGraph.Merge(existingGraph, runtimeGraph);
         }
 
-        private void ValidateImports(RuntimeGraph runtimeGraph, IDictionary<string, string> externalRIDs)
+        private void ValidateImports(RuntimeGraph runtimeGraph, Dictionary<string, string> externalRIDs)
         {
             foreach (var runtimeDescription in runtimeGraph.Runtimes.Values)
             {
@@ -328,7 +328,7 @@ private void AddRuntimeIdentifiers(ICollection<RuntimeGroup> runtimeGroups)
             }
         }
 
-        private static IDictionary<string, IEnumerable<string>> GetCompatibilityMap(RuntimeGraph graph)
+        private static Dictionary<string, IEnumerable<string>> GetCompatibilityMap(RuntimeGraph graph)
         {
             Dictionary<string, IEnumerable<string>> compatibilityMap = new Dictionary<string, IEnumerable<string>>();
 
@@ -350,7 +350,7 @@ private static IDictionary<string, IEnumerable<string>> ReadCompatibilityMap(str
             }
         }
 
-        private static void WriteCompatibilityMap(IDictionary<string, IEnumerable<string>> compatibilityMap, string mapFile)
+        private static void WriteCompatibilityMap(Dictionary<string, IEnumerable<string>> compatibilityMap, string mapFile)
         {
             var serializer = new JsonSerializer()
             {

src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Symbols.vb

@@ -1376,7 +1376,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
                             If declaringType.IsConstructedGenericType Then
                                 declaringType = declaringType.GetGenericTypeDefinition
                             End If
-                            Dim rawMethod As MethodBase = Nothing
+                            Dim rawMethod As MethodInfo = Nothing
                             For Each candidate As MethodInfo In declaringType.GetTypeInfo.GetDeclaredMethods(item.Name)
                                 If candidate.HasSameMetadataDefinitionAs(item) Then
                                     rawMethod = candidate

src/libraries/System.Collections.Concurrent/src/System/Collections/Concurrent/PartitionerStatic.cs

@@ -504,7 +504,7 @@ public override IList<IEnumerator<KeyValuePair<long, TSource>>> GetOrderablePart
                 IEnumerator<KeyValuePair<long, TSource>>[] partitions
                     = new IEnumerator<KeyValuePair<long, TSource>>[partitionCount];
 
-                IEnumerable<KeyValuePair<long, TSource>> partitionEnumerable = new InternalPartitionEnumerable(_source.GetEnumerator(), _useSingleChunking, true);
+                var partitionEnumerable = new InternalPartitionEnumerable(_source.GetEnumerator(), _useSingleChunking, true);
                 for (int i = 0; i < partitionCount; i++)
                 {
                     partitions[i] = partitionEnumerable.GetEnumerator();

src/libraries/System.Collections.Specialized/src/System/Collections/Specialized/StringCollection.cs

@@ -235,12 +235,10 @@ IEnumerator IEnumerable.GetEnumerator()
     public class StringEnumerator
     {
         private readonly System.Collections.IEnumerator _baseEnumerator;
-        private readonly System.Collections.IEnumerable _temp;
 
         internal StringEnumerator(StringCollection mappings)
         {
-            _temp = (IEnumerable)(mappings);
-            _baseEnumerator = _temp.GetEnumerator();
+            _baseEnumerator = ((IEnumerable)mappings).GetEnumerator();
         }
 
         public string? Current

src/libraries/System.ComponentModel.Annotations/src/System/ComponentModel/DataAnnotations/UIHintAttribute.cs

@@ -159,9 +159,9 @@ public override bool Equals([NotNullWhen(true)] object? obj)
             /// <returns>
             ///     Dictionary of control parameters.
             /// </returns>
-            private IDictionary<string, object?> BuildControlParametersDictionary()
+            private Dictionary<string, object?> BuildControlParametersDictionary()
             {
-                IDictionary<string, object?> controlParameters = new Dictionary<string, object?>();
+                var controlParameters = new Dictionary<string, object?>();
 
                 object?[]? inputControlParameters = _inputControlParameters;