Skip to content

Commit 1633968

Browse files
committed
Address PR and rebase to main
Rebased to current main, updated the commit messages and added the remaining changes to address the PR comments.
1 parent e349b33 commit 1633968

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/libraries/System.Net.WebSockets/tests/WebSocketCloseTests.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public WebSocketCloseTests()
4343
public void WebSocketReceiveResult_WebSocketCloseStatus_Roundtrip(WebSocketCloseStatus closeStatus)
4444
{
4545
string closeStatusDescription = "closeStatus " + closeStatus.ToString();
46-
WebSocketReceiveResult wsrr = new WebSocketReceiveResult(42, WebSocketMessageType.Close, true, closeStatus, closeStatusDescription);
46+
WebSocketReceiveResult wsrr = new WebSocketReceiveResult(42, WebSocketMessageType.Close, endOfMessage: true, closeStatus, closeStatusDescription);
4747
Assert.Equal(42, wsrr.Count);
4848
Assert.Equal(closeStatus, wsrr.CloseStatus);
4949
Assert.Equal(closeStatusDescription, wsrr.CloseStatusDescription);
@@ -57,16 +57,16 @@ public async Task ReceiveAsync_ValidCloseStatus_Success(WebSocketCloseStatus clo
5757
WebSocketTestStream stream = new();
5858
Encoding encoding = Encoding.UTF8;
5959

60-
using (WebSocket server = WebSocket.CreateFromStream(stream, isServer: true, null, TimeSpan.FromSeconds(3)))
61-
using (WebSocket client = WebSocket.CreateFromStream(stream.Remote, isServer: false, null, TimeSpan.FromSeconds(3)))
60+
using (WebSocket server = WebSocket.CreateFromStream(stream, isServer: true, subProtocol: null, TimeSpan.FromSeconds(3)))
61+
using (WebSocket client = WebSocket.CreateFromStream(stream.Remote, isServer: false, subProtocol: null, TimeSpan.FromSeconds(3)))
6262
{
6363
Assert.NotNull(server);
6464
Assert.NotNull(client);
6565

6666
// send something
6767
string hello = "Testing " + closeStatus.ToString();
6868
byte[] sendBytes = encoding.GetBytes(hello);
69-
await server.SendAsync(sendBytes.AsMemory(), WebSocketMessageType.Text, WebSocketMessageFlags.DisableCompression, CancellationToken);
69+
await server.SendAsync(sendBytes.AsMemory(), WebSocketMessageType.Text, WebSocketMessageFlags.None, CancellationToken);
7070

7171
// and then server-side close with the test status
7272
string closeStatusDescription = "CloseStatus " + closeStatus.ToString();
@@ -82,7 +82,7 @@ public async Task ReceiveAsync_ValidCloseStatus_Success(WebSocketCloseStatus clo
8282
WebSocketReceiveResult closing = await client.ReceiveAsync(new ArraySegment<byte>(receiveBuffer), CancellationToken);
8383
Assert.Equal(WebSocketMessageType.Close, closing.MessageType);
8484
Assert.Equal(closeStatus, closing.CloseStatus);
85-
Assert.Equal(serverMessage, closing.CloseStatusDescription);
85+
Assert.Equal(closeStatusDescription, closing.CloseStatusDescription);
8686
}
8787
}
8888
}

0 commit comments

Comments
 (0)