Skip to content

Commit 115a475

Browse files
authored
MetricEventSource tests workaround .NET Framework double rounding (#86286)
Fixes #85290 Desktop .NET Framework on x86 improperly rounds double values in some circumstances. I switched the test to use a lower precision double value so that it is not impacted by the extra rounding.
1 parent 2c6c003 commit 115a475

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/libraries/System.Diagnostics.DiagnosticSource/tests/MetricEventSourceTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -594,7 +594,7 @@ public void EventSourcePublishesAllDataTypes()
594594
l.Add(123_456_789_012);
595595
dec.Add(123_456_789_012_345);
596596
f.Add(123_456.789F);
597-
d.Add(87_654_321_987_654.4);
597+
d.Add(5.25);
598598

599599
i.Add(1);
600600
s.Add(1);
@@ -611,7 +611,7 @@ public void EventSourcePublishesAllDataTypes()
611611
l.Add(123_456_789_012);
612612
dec.Add(123_456_789_012_345);
613613
f.Add(123_456.789F);
614-
d.Add(87_654_321_987_654.4);
614+
d.Add(5.25);
615615

616616
i.Add(1);
617617
s.Add(1);
@@ -632,7 +632,7 @@ public void EventSourcePublishesAllDataTypes()
632632
AssertCounterEventsPresent(events, meter.Name, l.Name, "", "", ("123456789013", "123456789013"), ("123456789013", "246913578026"));
633633
AssertCounterEventsPresent(events, meter.Name, dec.Name, "", "", ("123456789012346", "123456789012346"), ("123456789012346", "246913578024692"));
634634
AssertCounterEventsPresent(events, meter.Name, f.Name, "", "", ("123457.7890625", "123457.7890625"), ("123457.7890625", "246915.578125"));
635-
AssertCounterEventsPresent(events, meter.Name, d.Name, "", "", ("87654321987655.4", "87654321987655.4"), ("87654321987655.4", "175308643975310.8"));
635+
AssertCounterEventsPresent(events, meter.Name, d.Name, "", "", ("6.25", "6.25"), ("6.25", "12.5"));
636636
AssertCollectStartStopEventsPresent(events, IntervalSecs, 3);
637637
}
638638

0 commit comments

Comments
 (0)