[Tests] Update to Appium 5.0.0 (#23118)

* Update to appium 5.0.0

Their driver has some removed methods (LaunchApp/CloseApp) which seem to be now implemented for windows.

Also removed an extra explicit ref to system.drawing.common since it comes in transitively from appium.webdriver package (and the version was causing issues since the newer appium.webdriver uses a newer version).

* Fix windows launchapp/closeapp for newer appium

In Appium's dotnet driver in v5.0.0 they removed `LaunchApp` from the driver: appium/dotnet-client#766

The deprecation suggests using `ActivateApp` as an alternative, but that throws an error saying it's not implemented on the windows driver.

Curiously, `CloseApp` which was also marked as deprecated was _moved_ from the base appium driver to the `WindowsDriver` here: appium/dotnet-client#773

I think the same treatment should have been done to the `LaunchApp` method since there's no alternative in windows.

For now the workaround is to invoke the command manually:
`windowsDriver.ExecuteScript("windows: launchApp", [_app.GetAppId()]);`

Author: Redth

src/Controls/tests/TestCases.Android.Tests/Controls.TestCases.Android.Tests.csproj

@@ -10,7 +10,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Appium.WebDriver" Version="5.0.0-rc.7" />
+    <PackageReference Include="Appium.WebDriver" Version="5.0.0" />
     <PackageReference Include="NUnit" Version="4.0.1" />
     <PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
   </ItemGroup>

src/Controls/tests/TestCases.Mac.Tests/Controls.TestCases.Mac.Tests.csproj

@@ -10,7 +10,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Appium.WebDriver" Version="5.0.0-rc.7" />
+    <PackageReference Include="Appium.WebDriver" Version="5.0.0" />
     <PackageReference Include="NUnit" Version="4.0.1" />
     <PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
   </ItemGroup>

src/Controls/tests/TestCases.WinUI.Tests/Controls.TestCases.WinUI.Tests.csproj

@@ -10,7 +10,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Appium.WebDriver" Version="5.0.0-rc.7" />
+    <PackageReference Include="Appium.WebDriver" Version="5.0.0" />
     <PackageReference Include="NUnit" Version="4.0.1" />
     <PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
   </ItemGroup>

src/Controls/tests/TestCases.iOS.Tests/Controls.TestCases.iOS.Tests.csproj

@@ -10,7 +10,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Appium.WebDriver" Version="5.0.0-rc.7" />
+    <PackageReference Include="Appium.WebDriver" Version="5.0.0" />
     <PackageReference Include="NUnit" Version="4.0.1" />
     <PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
   </ItemGroup>

src/TestUtils/src/UITest.Appium/Actions/AppiumLifecycleActions.cs

@@ -55,19 +55,21 @@ CommandResponse LaunchApp(IDictionary<string, object> parameters)
 				return CommandResponse.FailedEmptyResponse;
 
 			if (_app.GetTestDevice() == TestDevice.Mac)
-			{	
+			{
 				_app.Driver.ExecuteScript("macos: activateApp", new Dictionary<string, object>
 				{
 					{ "bundleId", _app.GetAppId() },
 				});
 			}
-			else if (_app.GetTestDevice() == TestDevice.Windows)
+			else if (_app.Driver is WindowsDriver windowsDriver)
 			{
-#pragma warning disable CS0618 // Type or member is obsolete
-				_app.Driver.LaunchApp();
-#pragma warning restore CS0618 // Type or member is obsolete
+				// Appium driver removed the LaunchApp method in 5.0.0, so we need to use the executeScript method instead
+				// Currently the appium-windows-driver reports the following commands as compatible:
+				//   startRecordingScreen,stopRecordingScreen,launchApp,closeApp,deleteFile,deleteFolder,
+				//   click,scroll,clickAndDrag,hover,keys,setClipboard,getClipboard
+				windowsDriver.ExecuteScript("windows: launchApp", [_app.GetAppId()]);
 			}
-			else 
+			else
 			{
 				_app.Driver.ActivateApp(_app.GetAppId());
 			}
@@ -127,7 +129,7 @@ CommandResponse CloseApp(IDictionary<string, object> parameters)
 			}
 			catch (Exception)
 			{
-				// TODO Pass in logger so we can log these exceptions
+				// TODO: Pass in logger so we can log these exceptions
 
 				// Occasionally the app seems to get so locked up it can't 
 				// even report back the appstate. In that case, we'll just
@@ -143,11 +145,12 @@ CommandResponse CloseApp(IDictionary<string, object> parameters)
 						{ "bundleId", _app.GetAppId() },
 					});
 				}
-				else if (_app.GetTestDevice() == TestDevice.Windows)
+				else if (_app.Driver is WindowsDriver windowsDriver)
 				{
-	#pragma warning disable CS0618 // Type or member is obsolete
-					_app.Driver.CloseApp();
-	#pragma warning restore CS0618 // Type or member is obsolete
+					// This is still here for now, but it looks like it will get removed just like
+					// LaunchApp was in 5.0.0, in which case we may need to use:
+					// windowsDriver.ExecuteScript("windows: closeApp", [_app.GetAppId()]);
+					windowsDriver.CloseApp();
 				}
 				else
 				{

src/TestUtils/src/UITest.Appium/UITest.Appium.csproj

@@ -7,8 +7,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Appium.WebDriver" Version="5.0.0-rc.7" />
-    <PackageReference Include="System.Drawing.Common" Version="8.0.3" />
+    <PackageReference Include="Appium.WebDriver" Version="5.0.0" />
   </ItemGroup>
 
   <ItemGroup>