Skip to content

Commit 5e3e017

Browse files
[Java.Runtime.Environment] don't call PeekPeer() inside AddPeer()
Context: dotnet/android#10004 This breaks the "replaceable" logic otherwise.
1 parent 7b7ae83 commit 5e3e017

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

src/Java.Runtime.Environment/Java.Interop/ManagedValueManager.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,6 @@ public override void AddPeer (IJavaPeerable value)
5757
var r = value.PeerReference;
5858
if (!r.IsValid)
5959
throw new ObjectDisposedException (value.GetType ().FullName);
60-
var o = PeekPeer (value.PeerReference);
61-
if (o != null)
62-
return;
6360

6461
if (r.Type != JniObjectReferenceType.Global) {
6562
value.SetPeerReference (r.NewGlobalRef ());

src/Java.Runtime.Environment/Java.Interop/MonoRuntimeValueManager.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,6 @@ public override void AddPeer (IJavaPeerable value)
124124
var r = value.PeerReference;
125125
if (!r.IsValid)
126126
throw new ObjectDisposedException (value.GetType ().FullName);
127-
var o = PeekPeer (value.PeerReference);
128-
if (o != null)
129-
return;
130127

131128
if (r.Type != JniObjectReferenceType.Global) {
132129
value.SetPeerReference (r.NewGlobalRef ());

0 commit comments

Comments
 (0)