Skip to content

Incorrect method name - AddServiceLogEnricher #6504

@evgenyfedorov2

Description

@evgenyfedorov2

Description

.AddServiceLogEnricher() method with its overloads

public static IServiceCollection AddServiceLogEnricher(this IServiceCollection services)

public static IServiceCollection AddServiceLogEnricher(this IServiceCollection services, Action<ApplicationLogEnricherOptions> configure)

public static IServiceCollection AddServiceLogEnricher(this IServiceCollection services, IConfigurationSection section)

have incorrect names: it should be .AddApplicationLogEnricher(), because the underlying class has this name

internal sealed class ApplicationLogEnricher : IStaticLogEnricher
as well as the Extensions class

This seems to be an oversight during some renaming from Service* to Application*.

Reproduction Steps

n/a

Expected behavior

Extension methods have names .AddApplicationLogEnricher()

Actual behavior

Extension methods have names .AddServiceLogEnricher()

Regression?

No

Known Workarounds

n/a

Configuration

No response

Other information

Just rename the methods, probably in a non-breaking fashion - introduce new methods, deprecate old ones

Sub-issues

Metadata

Metadata

Labels

area-telemetrybugThis issue describes a behavior which is not expected - a bug.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions