Skip to content

ML Notebook improvements #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 5 tasks
luisquintanilla opened this issue Jun 2, 2022 · 7 comments
Open
2 of 5 tasks

ML Notebook improvements #39

luisquintanilla opened this issue Jun 2, 2022 · 7 comments

Comments

@luisquintanilla
Copy link
Contributor

luisquintanilla commented Jun 2, 2022

Thanks @andrasfuchs for trying out the notebooks and providing feedback:

This feedback is specific to the Training and AutoML notebook, but it's also good feedback in general to follow across notebooks.

  • The capitalization of "ML.NET" is not consistent in the document

  • The "This notebook is under active development" is barely visible with Visual Studio's dark theme
    image

  • The tutorial is easy to follow, I just missed the links to the different classes and methods (like .Fit, IDataView, Regression.Trainers, TrainTestSplit, etc.), because although they are familiar it would be nice to have a way to jump to that particular class or method to investigate it further. F1 doesn't seem to work as it normally does when I browse my own code.

  • It would have been a little better if the sample datasets had more than one feature columns, just to see how Transforms.Concatenate should look like in that case

  • In the "Use AutoML..." section when I run the code, it only showed a grey rectangle while it was running, and when it finished it remained a grey and made all the other previous outputs shown as grey rectangles.

    image

    When I closed the file, reopened it and clicked "Run All", I got the following exception:

    image

@luisquintanilla luisquintanilla changed the title Notebok improvements ML Notebook improvements Jun 2, 2022
@luisquintanilla
Copy link
Contributor Author

@LittleLittleCloud do you know why the grey box / exception might be happening?

@JakeRadMSFT
Copy link
Contributor

I believe it's related to throughput issue with Daytona/WebView2. Oddly enough ... I think it mostly happens on very powerful machines.

@andrasfuchs is your machine fairly powerful?

I thought I decreased the occurrence of this issue but I'll need to dig in more.

@JakeRadMSFT
Copy link
Contributor

Also thanks so much for trying it out @andrasfuchs!! We'll work to resolve that feedback in the Notebooks.

@andrasfuchs
Copy link

@JakeRadMSFT Relatively yes, 6-core Ryzen 5 3600 CPU, 32 GB RAM, NVIDIA RTX 3070 Ti GPU.
I'm not sure it matters, but I have many background processes running normally and my GPU is constantly under 90%+ load.

I don't know if it's related, but I noticed before a few times that during some Model Builder training sessions in Visual Studio the AutoML trainer started to eat up all the memory that I have left, and Windows started to hang more and more, so I needed to terminate the training process. I couldn't figure out how to reliably reproduce it though.

@JakeRadMSFT
Copy link
Contributor

@andrasfuchs can you try out the latest version of the notebooks? Perf should be improved and the grey boxes should be gone :)

@andrasfuchs
Copy link

@JakeRadMSFT I'd love to, but I'm abroad for a few weeks and I have limited internet access. I'll get back to you when I'm home again.

@andrasfuchs
Copy link

andrasfuchs commented Jul 4, 2022

@JakeRadMSFT Today I run the code snippets in the notebook again, and it got significantly better. The UI is more responsive, it feels quicker too.

I noticed four small, low-priority things:

  • One of the sample codes run for 300 seconds. I think that's a little too much since it's just a tech demo, so I think ~30 seconds would give a better UX.
    image
  • There is a relatively wide table under the chart, and I think the horizontal scrollbar is a little difficult to find. The values in its last Parameters column are difficult to read, it would be nice to have a pretty formatting for that parameters array.
    image
  • Scrolling with the mouse wheel doesn't work if the cursor is above one of the results (under the code snippets). You can test this by running a few of the snippets, go to the top of the page, and start scrolling down by using the mouse wheel. It will stop working as soon as you reach a section with results.
    image
  • When I scroll down in the notebook without clicking into it, and I switch another window (with alt+tab) and come back again to Visual Studio, the notebook loses it's last scrolling position and I'm back at the top of the notebook. If I clicked into a section and scrolled further down before switching then when I switch back the notebook jumps to the clicked section.

I also experienced a Windows-hanging situation again that I suspect to be a memory-leak within the notebook, but I want to investigate it a little further. I think that is a more serious problem, so it's worth a separate issue. I'll create a new issue for that if I'm able to reproduce it a few more times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants