-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Storage component doesn't work with Azure Storage RunAsEmulator #5078
Comments
I think this is an issue we would service for in an ideal world. Workaround is to use: var blobs = builder.AddAzureStorage("Storage")
// Use the Azurite storage emulator for local development
.RunAsEmulator(emulator => emulator.WithImageTag("3.31.0"))
.AddBlobs("BlobConnection"); |
We hit this earlier too - #4646 ! |
We need a test here, if it broke us twice. |
Great find. I agree that we should have a test for this. Is the fix essentially to bump the tag to the new version then? If so we can just do that and ship next month, and folks hitting this can use your workaround. |
* [tests] Add AzureStorageEmulatorFunctionalTests * Bump azurite from 3.30.0 to 3.31.0 Issue: #5078 * Address PR feedback --------- Co-authored-by: Eric Erhardt <[email protected]>
commit c680699 Merge: 9e48bf0 8b603ea Author: Ankit Jain <[email protected]> Date: Fri Jul 26 18:14:38 2024 -0400 Merge remote-tracking branch 'origin/main' into playground-tests-prep commit 9e48bf0 Author: Ankit Jain <[email protected]> Date: Fri Jul 26 18:14:29 2024 -0400 Fix up import conditions commit b1726a2 Author: Ankit Jain <[email protected]> Date: Fri Jul 26 17:54:59 2024 -0400 Update Aspire.sln to track the project name changes commit 8b603ea Author: Ankit Jain <[email protected]> Date: Fri Jul 26 14:57:19 2024 -0400 Fix Azure Storage `RunAsEmulator` (dotnet#5084) * [tests] Add AzureStorageEmulatorFunctionalTests * Bump azurite from 3.30.0 to 3.31.0 Issue: dotnet#5078 * Address PR feedback --------- Co-authored-by: Eric Erhardt <[email protected]> commit bc27dba Author: Ankit Jain <[email protected]> Date: Thu Jul 25 18:20:53 2024 -0400 [playground] Update all ProjectReferences to AspireProjectOrPackageReference. And skip Dashboard.csproj when building for testing commit 13a1550 Author: Ankit Jain <[email protected]> Date: Thu Jul 25 17:26:42 2024 -0400 [playground] Add top level Directory.Build.{props,targets} And use Aspire.RepoTesting.* to allow testing and this replaces the per-project sdk imports. commit 6d84aee Author: Ankit Jain <[email protected]> Date: Thu Jul 25 17:31:49 2024 -0400 [playground] Rename AppHost projects to be named consistently .. with `.AppHost` suffix. `Aspire.Hosting.Testing` specifically looks for a `.AppHost` suffix to identify apphost assemblies. commit 2a2e2b9 Author: Ankit Jain <[email protected]> Date: Thu Jul 25 17:27:06 2024 -0400 [playground] remove all the per-project Directory.Build.{props,targets} # Conflicts: # playground/Directory.Build.props # playground/Directory.Build.targets # playground/dapr/AppHost/DaprAppHost.csproj # playground/dapr/AppHost/Program.cs # playground/dapr/AppHost/Properties/launchSettings.json # playground/dapr/AppHost/aspire-manifest.json # playground/dapr/Dapr.AppHost/Dapr.AppHost.csproj # playground/dapr/Dapr.AppHost/Program.cs # playground/dapr/Dapr.AppHost/Properties/launchSettings.json # playground/dapr/Dapr.AppHost/appsettings.json # playground/dapr/Dapr.AppHost/aspire-manifest.json # playground/dapr/dapr.AppHost/Dapr.AppHost.csproj # playground/dapr/dapr.AppHost/Program.cs # playground/dapr/dapr.AppHost/Properties/launchSettings.json # playground/dapr/dapr.AppHost/appsettings.json # playground/dapr/dapr.AppHost/aspire-manifest.json # playground/orleans/OrleansAppHost/appsettings.json
Repro Steps
In your AppHost:
In your webfrontend project:
var builder = WebApplication.CreateBuilder(args); // Add service defaults & Aspire components. builder.AddServiceDefaults(); // add this line builder.AddAzureBlobClient("BlobConnection");
F5
hit the
webfrontend/health
endpointExpected results
Healthy
Actual results
Unhealthy
Logs
If we update to image tag
3.31.0
here, the problem goes away:aspire/src/Aspire.Hosting.Azure.Storage/AzureStorageExtensions.cs
Lines 114 to 119 in e0552c0
The text was updated successfully, but these errors were encountered: