Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pre-provisioned configuration for azure resources #2395

Closed
davidfowl opened this issue Feb 24, 2024 · 4 comments
Closed

Support pre-provisioned configuration for azure resources #2395

davidfowl opened this issue Feb 24, 2024 · 4 comments
Assignees
Labels
area-integrations Issues pertaining to Aspire Integrations packages azure Issues associated specifically with scenarios tied to using Azure
Milestone

Comments

@davidfowl
Copy link
Member

We removed the ability to specify a connection string directly for arbitrary resources now that we have the AddConnectionString method. This adds a bit of friction when you want to directly specify the information for pre-provisioned to be used in development, while still allowing them to be provisioned during deployment.

@davidfowl davidfowl added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication azure Issues associated specifically with scenarios tied to using Azure labels Feb 24, 2024
@davidfowl davidfowl added this to the preview 4 (Mar) milestone Feb 24, 2024
@davidfowl davidfowl self-assigned this Feb 24, 2024
@davidfowl
Copy link
Member Author

davidfowl commented Feb 27, 2024

Moving this to preview 5. The preview 4 mode of operation will be something like this:

var keyVault = builder.ExecutionContext.IsPublishMode ? 
        builder.AddKeyVault("kv") : 
        builder.AddConnectionString("kv");

builder.AddProject<Projects.Api>("api").WithReference(kv);

We'll add the ability to use an existing resource in preview 5

@mitchdenny
Copy link
Member

For GA we'll do use AddConnectionString(...).

@captainsafia
Copy link
Member

I'm taking a look at this in reaction to the feedback we received from the Aspire + Azure Functions work.

@captainsafia
Copy link
Member

Closing this out for 9.1 as a bulk of the work has been done here.

Docs issue for this is over at dotnet/docs-aspire#2549.

We can consider additional enchancements like #7514 to this in the future.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages azure Issues associated specifically with scenarios tied to using Azure
Projects
None yet
Development

No branches or pull requests

5 participants