Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maestro sometimes doesn't add darc feeds to nuget.config #4153

Open
dkurepa opened this issue Nov 15, 2024 · 1 comment
Open

Maestro sometimes doesn't add darc feeds to nuget.config #4153

dkurepa opened this issue Nov 15, 2024 · 1 comment

Comments

@dkurepa
Copy link
Member

dkurepa commented Nov 15, 2024

This is something I've been noticing for a while, and also something our customers reported recently: https://teams.microsoft.com/l/message/19:[email protected]/1731647680149?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=4d73664c-9f2f-450d-82a5-c2f02756606d&parentMessageId=1731647680149&teamName=.NET%20Core%20Eng%20Services%20Partners&channelName=First%20Responders&createdTime=1731647680149.

Basically, when we're flowing stabilized packages through Maestro, sometimes the temporary darc feed containing the package is not added to nuget.config, even tho the build has assets in it. This causes PR failures and needs manual intervention to be resolved

@mmitche
Copy link
Member

mmitche commented Nov 20, 2024

This is because a new build of the same sha did not get published (typically because it was on a different branch). When two builds have the same sha and same version numbers for a given asset, maestro chooses the newest one. It has no easy way to disambiguate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants