[nativeaot] run Mono.Android-Tests

* Add Categories Export, GCBridge

* Add Mono category

* Setup `TestApkFeeds.props`

/Users/runner/work/1/s/tests/Mono.Android-Tests/Mono.Android-Tests/Mono.Android.NET-Tests.csproj : error NU1102: Unable to find package Microsoft.Android.Runtime.NativeAOT.35.android-arm64 with version (= 35.99.0-ci.dev-peppers-mono-android-tests-nativeaot.229)

[nativeaot] fix default `SynchronizationContext`

Running `Mono.Android-Tests` under NativeAOT has the test failure:

    03-04 23:06:20.021  6191  6211 I NUnit   : SynchronizationContext_Is_ThreadingSynchronizationContextCurrent
    03-04 23:06:20.032  6191  6211 E NUnit   : 	[FAIL]
    03-04 23:06:20.032  6191  6211 E NUnit   :  :   Expected: True
    03-04 23:06:20.032  6191  6211 E NUnit   :   But was:  False
    03-04 23:06:20.032  6191  6211 E NUnit   :    at libMono.Android.NET-Tests!<BaseAddress>+0x1482f63
    03-04 23:06:20.032  6191  6211 E NUnit   :    at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0xf3

Initially, if we called `JNIEnvInit.SetSynchronizationContext()` at
startup, this can result in the static ctor for
`Android.App.Application` running *too soon* before
`JNIEnvInit.InitializeJniRuntime()` has completed.

To fix this:

* Add an empty `static ctor` to `Android.App.Application` to remove
  the `beforefieldinit` flag from the type.

* Call `JNIEnvInit.SetSynchronizationContext()` at startup for NativeAOT.

With this change in place, no crashes occur at startup and the test
passes.

* Fix `EmbeddedResources_ShouldBeLocalized` test

Author: jonathanpeppers

build-tools/automation/yaml-templates/stage-package-tests.yaml

@@ -198,6 +198,16 @@ stages:
         artifactSource: bin/Test$(XA.Build.Configuration)/$(DotNetTargetFramework)-android/Mono.Android.NET_Tests-Signed.aab
         artifactFolder: $(DotNetTargetFramework)-AotLlvm
 
+    - template: /build-tools/automation/yaml-templates/apk-instrumentation.yaml
+      parameters:
+        configuration: $(XA.Build.Configuration)
+        testName: Mono.Android.NET_Tests-NativeAOT
+        project: tests/Mono.Android-Tests/Mono.Android-Tests/Mono.Android.NET-Tests.csproj
+        testResultsFiles: TestResult-Mono.Android.NET_Tests-$(XA.Build.Configuration)NativeAOT.xml
+        extraBuildArgs: -p:TestsFlavor=NativeAOT -p:PublishAot=true
+        artifactSource: bin/Test$(XA.Build.Configuration)/$(DotNetTargetFramework)-android/Mono.Android.NET_Tests-Signed.aab
+        artifactFolder: $(DotNetTargetFramework)-NativeAOT
+
     - template: /build-tools/automation/yaml-templates/apk-instrumentation.yaml
       parameters:
         configuration: $(XA.Build.Configuration)

build-tools/scripts/TestApkFeeds.props

@@ -0,0 +1,8 @@
+<!-- Needed for projects using CoreCLR/NativeAOT runtime packs that are not in the workload -->
+<Project>
+  <PropertyGroup Condition=" '$(RunningOnCI)' == 'true' ">
+    <_NuGetFolderOnCI>$(MSBuildThisFileDirectory)..\..\bin\Build$(Configuration)\nuget-unsigned</_NuGetFolderOnCI>
+    <RestoreAdditionalProjectSources Condition="Exists('$(_NuGetFolderOnCI)')">$(_NuGetFolderOnCI)</RestoreAdditionalProjectSources>
+    <_FastDeploymentDiagnosticLogging>true</_FastDeploymentDiagnosticLogging>
+  </PropertyGroup>
+</Project>

build-tools/scripts/TestApks.targets

@@ -17,8 +17,8 @@
   <UsingTask AssemblyFile="$(PrepTasksAssembly)" TaskName="Xamarin.Android.BuildTools.PrepTasks.ProcessApkSizes" />
 
   <PropertyGroup>
-    <!-- APK tests might run on 32-bit emulators -->
-    <RuntimeIdentifiers Condition=" '$(RuntimeIdentifier)' == '' ">android-arm64;android-x86;android-x64;</RuntimeIdentifiers>
+    <!-- Mono APK tests might run on 32-bit emulators -->
+    <RuntimeIdentifiers Condition=" '$(RuntimeIdentifier)' == '' and '$(PublishAot)' != 'true' and '$(UseMonoRuntime)' != 'false' ">android-arm64;android-x86;android-x64;</RuntimeIdentifiers>
     <TestAvdApiLevel Condition=" '$(TestAvdApiLevel)' == '' ">29</TestAvdApiLevel>
     <TestAvdAbi Condition=" '$(TestAvdAbi)' == '' and '$(HostOS)' == 'Darwin' and  '$(HostOSArchitecture)' == 'Arm64' ">arm64-v8a</TestAvdAbi>
     <TestAvdAbi Condition=" '$(TestAvdAbi)' == '' ">x86_64</TestAvdAbi>

samples/NativeAOT/NativeAOT.csproj

@@ -13,11 +13,6 @@
     <PublishAot>true</PublishAot>
   </PropertyGroup>
 
-  <!-- Settings for CI -->
-  <PropertyGroup Condition=" '$(RunningOnCI)' == 'true' ">
-    <_NuGetFolderOnCI>..\..\bin\Build$(Configuration)\nuget-unsigned</_NuGetFolderOnCI>
-    <RestoreAdditionalProjectSources Condition="Exists('$(_NuGetFolderOnCI)')">$(_NuGetFolderOnCI)</RestoreAdditionalProjectSources>
-    <_FastDeploymentDiagnosticLogging>true</_FastDeploymentDiagnosticLogging>
-  </PropertyGroup>
+  <Import Project="..\..\build-tools\scripts\TestApkFeeds.props" />
 
 </Project>

tests/Mono.Android-Tests/Java.Interop-Tests/Java.InteropTests/AndroidValueManagerContractTests.cs

@@ -2,6 +2,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using System.Reflection;
 using System.Threading;
@@ -11,9 +12,10 @@
 using NUnit.Framework;
 
 namespace Java.InteropTests {
-	[TestFixture]
+	[TestFixture, Category ("Mono")]
 	public class AndroidValueManagerContractTests : JniRuntimeJniValueManagerContract {
 
+		[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)]
 		protected override Type ValueManagerType => typeof (Android.Runtime.AndroidValueManager);
 	}
 }

tests/Mono.Android-Tests/Mono.Android-Tests/Android.Runtime/JnienvArrayMarshaling.cs

@@ -91,7 +91,7 @@ public void CopyArray_JavaLangStringArrayArrayToSystemStringArrayArray ()
 			}
 		}
 
-		[Test]
+		[Test, Ignore ("TODO hangs test suite")]
 		public void CopyArray_JavaLangObjectArrayToJavaLangStringArray ()
 		{
 			using (var stringArray = new Java.Lang.Object (JNIEnv.NewArray (new[]{"a", "b"}), JniHandleOwnership.TransferLocalRef)) {

tests/Mono.Android-Tests/Mono.Android-Tests/Java.Interop/JnienvTest.cs

@@ -238,7 +238,7 @@ public void SetField_PermitNullValues ()
 			}
 		}
 
-		[Test]
+		[Test, Category ("Export")]
 		public void CreateTypeWithExportedMethods ()
 		{
 			using (var e = new ContainsExportedMethods ()) {
@@ -250,7 +250,7 @@ public void CreateTypeWithExportedMethods ()
 			}
 		}
 
-		[Test]
+		[Test, Category ("Export")]
 		public void ActivatedDirectObjectSubclassesShouldBeRegistered ()
 		{
 			if (Build.VERSION.SdkInt <= BuildVersionCodes.GingerbreadMr1)
@@ -405,7 +405,7 @@ public void MoarThreadingTests ()
 			Assert.IsNull (ignore_t2, string.Format ("No exception should be thrown [t2]! Got: {0}", ignore_t2));
 		}
 
-		[Test]
+		[Test, Category ("Mono")]
 		public void JavaToManagedTypeMapping ()
 		{
 			Type m = Java.Interop.TypeManager.GetJavaToManagedType ("android/content/res/Resources");
@@ -414,7 +414,7 @@ public void JavaToManagedTypeMapping ()
 			Assert.AreEqual (null, m);
 		}
 
-		[Test]
+		[Test, Category ("Mono")]
 		public void ManagedToJavaTypeMapping ()
 		{
 			Type type = typeof(Activity);
@@ -426,7 +426,7 @@ public void ManagedToJavaTypeMapping ()
 			Assert.AreEqual (null, m, "`JnienvTest` does *not* subclass Java.Lang.Object, it should *not* be in the typemap!");
 		}
 
-		[Test]
+		[Test, Category ("GCBridge")]
 		public void DoNotLeakWeakReferences ()
 		{
 			GC.Collect ();

tests/Mono.Android-Tests/Mono.Android-Tests/Mono.Android.NET-Tests.csproj

@@ -1,6 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk" >
 
   <Import Project="..\..\..\Configuration.props" />
+  <Import Project="..\..\..\build-tools\scripts\TestApkFeeds.props" />
 
   <PropertyGroup>
     <TargetFramework>$(DotNetAndroidTargetFramework)</TargetFramework>
@@ -22,13 +23,17 @@
     <WarningsAsErrors>IL2037</WarningsAsErrors>
     <AndroidUseNegotiateAuthentication>true</AndroidUseNegotiateAuthentication>
     <AndroidNdkDirectory></AndroidNdkDirectory>
+    <DefineConstants Condition=" '$(UseMonoRuntime)' == 'false' ">$(DefineConstants);CORECLR</DefineConstants>
+    <DefineConstants Condition=" '$(PublishAot)' == 'true' ">$(DefineConstants);NATIVEAOT</DefineConstants>
     <!--
       TODO: Fix excluded tests
       For $(EnableLLVM)
         InetAccess excluded: https://github.com/dotnet/runtime/issues/73304
         NetworkInterfaces excluded: https://github.com/dotnet/runtime/issues/75155
     -->
     <ExcludeCategories>DotNetIgnore</ExcludeCategories>
+    <!-- Features that do not work on NativeAOT -->
+    <ExcludeCategories Condition=" '$(PublishAot)' == 'true' ">$(ExcludeCategories):Mono:Export:GCBridge</ExcludeCategories>
     <!-- FIXME: LLVMIgnore https://github.com/dotnet/runtime/issues/89190 -->
     <ExcludeCategories Condition=" '$(EnableLLVM)' == 'true' ">$(ExcludeCategories):LLVMIgnore</ExcludeCategories>
     <ExcludeCategories Condition=" '$(EnableLLVM)' == 'true' ">$(ExcludeCategories):InetAccess:NetworkInterfaces</ExcludeCategories>

tests/Mono.Android-Tests/Mono.Android-Tests/System.Net/SslTest.cs

@@ -27,6 +27,7 @@ bool ShouldIgnoreException (WebException wex)
 
 		// https://xamarin.desk.com/agent/case/35534
 		[Test]
+		[Ignore ("TODO crashes on NativeAOT")]
 		public void SslWithinTasksShouldWork ()
 		{
 			var cb = ServicePointManager.ServerCertificateValidationCallback;

tests/Mono.Android-Tests/Mono.Android-Tests/System/AppContextTests.cs

@@ -47,7 +47,7 @@ public void GetData (string name, string expected)
 			},
 		};
 
-		[Test]
+		[Test, Category ("Mono")]
 		[TestCaseSource (nameof (TestPrivateSwitchesSource))]
 		public void TestPrivateSwitches (
 				[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.All)]

tests/Mono.Android-Tests/Mono.Android-Tests/Xamarin.Android.Net/AndroidClientHandlerTests.cs

@@ -146,6 +146,7 @@ bool IgnoreIfConnectionFailed (WebException wex, out bool connectionFailed)
 		}
 	}
 
+	[Ignore ("TODO crashes on NativeAOT")]
 	public abstract class AndroidHandlerTestBase : HttpClientHandlerTestBase
 	{
 		static IEnumerable<Exception> Exceptions (Exception e)
@@ -314,7 +315,7 @@ public bool ShouldIgnoreSuccessStatusCode (HttpStatusCode code)
 		}
 	}
 
-	[TestFixture]
+	[TestFixture, Category ("Mono")]
 	public class AndroidClientHandlerTests : AndroidHandlerTestBase
 	{
 		protected override HttpMessageHandler CreateHandler ()

tests/Mono.Android-Tests/Mono.Android-Tests/Xamarin.Android.Net/AndroidMessageHandlerNegotiateAuthenticationTests.cs

@@ -14,6 +14,7 @@ namespace Xamarin.Android.NetTests {
 	// in the Mono.Android.NET-Tests.csproj file.
 	[TestFixture]
 	[Category ("InetAccess")]
+	[Ignore ("TODO crashes on NativeAOT")]
 	public sealed class AndroidMessageHandlerNegotiateAuthenticationTests
 	{
 		// Negotiate authentication is available for Android since .NET 7

tests/Mono.Android-Tests/Mono.Android-Tests/Xamarin.Android.Net/AndroidMessageHandlerTests.cs

@@ -14,6 +14,7 @@
 namespace Xamarin.Android.NetTests
 {
 	[TestFixture]
+	[Ignore ("TODO crashes on NativeAOT")]
 	public class AndroidMessageHandlerTests : AndroidHandlerTestBase
 	{
 		protected override HttpMessageHandler CreateHandler ()

tests/Mono.Android-Tests/Mono.Android-Tests/Xamarin.Android.Net/HttpClientIntegrationTests.cs

@@ -1062,6 +1062,7 @@ public static implicit operator HttpMessageHandler (AndroidHandlerSettingsAdapte
 	}
 
 	[TestFixture]
+	[Category ("Mono")]
 	public class AndroidClientHandlerIntegrationTests : HttpClientIntegrationTestBase
 	{
 		protected override AndroidHandlerSettingsAdapter CreateHandler ()

tests/Mono.Android-Tests/Mono.Android-Tests/Xamarin.Android.RuntimeTests/NUnitInstrumentation.cs

@@ -30,13 +30,17 @@ protected NUnitInstrumentation(IntPtr handle, JniHandleOwnership transfer)
         protected override IList<TestAssemblyInfo> GetTestAssemblies()
         {
             Assembly asm = Assembly.GetExecutingAssembly();
+            #if !NATIVEAOT && !CORECLR // TODO: Java.Interop-Tests not passing yet
             Assembly ji  = typeof (Java.InteropTests.JavaInterop_Tests_Reference).Assembly;
+            #endif
 
 
             return new List<TestAssemblyInfo>()
             {
                 new TestAssemblyInfo (asm, asm.Location ?? String.Empty),
+                #if !NATIVEAOT && !CORECLR
                 new TestAssemblyInfo (ji, ji.Location ?? String.Empty),
+                #endif
             };
         }
     }