Skip to content

Replace 'as' casts with explicit casts #4019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SimonCropp wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace 'as' casts with explicit casts #4019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73dac8e
Replace 'as' casts with explicit casts
SimonCropp Mar 7, 2026
2c99232
Update src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlD…
SimonCropp Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,10 +204,10 @@ private int RowNumber
switch (_rowSourceType)
{
case ValueSourceType.RowArray:
rowNo = ((DataTable)_dataTableSource).Rows.IndexOf(_rowEnumerator.Current as DataRow);
rowNo = ((DataTable)_dataTableSource).Rows.IndexOf((DataRow)_rowEnumerator.Current);
break;
case ValueSourceType.DataTable:
rowNo = ((DataTable)_rowSource).Rows.IndexOf(_rowEnumerator.Current as DataRow);
rowNo = ((DataTable)_rowSource).Rows.IndexOf((DataRow)_rowEnumerator.Current);
break;
case ValueSourceType.DbDataReader:
case ValueSourceType.IDataReader:
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlDataReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3103,7 +3103,7 @@ private T GetFieldValueFromSqlBufferInternal<T>(SqlBuffer data, _SqlMetaData met
{
throw SQL.JsonDocumentNotSupportedOnColumnType(metaData.column);
}
JsonDocument document = JsonDocument.Parse(data.Value as string);
JsonDocument document = JsonDocument.Parse(data.String);
return (T)(object)document;
}
else
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlDependency.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ private static void GetSerializedObject(SqlClientObjRef objRef, DataContractSeri
private static SqlDependencyProcessDispatcher GetDeserializedObject(DataContractSerializer serializer, MemoryStream stream)
{
object refResult = serializer.ReadObject(stream);
var result = RemotingServices.Unmarshal((refResult as SqlClientObjRef).GetObjRef());
var result = RemotingServices.Unmarshal(((SqlClientObjRef)refResult).GetObjRef());
return result as SqlDependencyProcessDispatcher;
}
#endif // NETFRAMEWORK
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlParameter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2390,11 +2390,11 @@ internal static object CoerceValue(object value, MetaType destinationType, out b
{
try
{
value = (new SqlVector<float>(JsonSerializer.Deserialize<float[]>(value as string)) as ISqlVector).VectorPayload;
value = ((ISqlVector)new SqlVector<float>(JsonSerializer.Deserialize<float[]>((string)value))).VectorPayload;
}
catch (Exception ex) when (ex is ArgumentNullException || ex is JsonException)
{
throw ADP.InvalidJsonStringForVector(value as string, ex);
throw ADP.InvalidJsonStringForVector((string)value, ex);
}
}
else if (
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.Data.SqlClient/tests/FunctionalTests/AADAuthenticationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ public void InvalidCombinationOfAccessToken(string description, object[] Params)
{
SecureString password = new SecureString();
password.MakeReadOnly();
_credential = new SqlCredential(Params[0] as string, password);
_credential = new SqlCredential((string)Params[0], password);
}
else
{
_builder[Params[0] as string] = Params[1];
_builder[(string)Params[0]] = Params[1];
}
InvalidCombinationCheck(_credential);
}
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionPoolTest/PoolBlockPeriodTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public class PoolBlockPeriodTest
public void TestAzureBlockingPeriod(string description, object[] Params)
{
string _ = description; // Using C# Discards as workaround to the XUnit warning.
string serverName = Params[0] as string;
string serverName = (string)Params[0];
PoolBlockingPeriod? policy = null;
if (Params.Length > 1)
{
Expand All @@ -60,7 +60,7 @@ public void TestAzureBlockingPeriod(string description, object[] Params)
public void TestNonAzureBlockingPeriod(string description, object[] Params)
{
string _ = description; // Using C# Discards as workaround to the XUnit warning.
string serverName = Params[0] as string;
string serverName = (string)Params[0];
PoolBlockingPeriod? policy = null;

if (Params.Length > 1)
Expand Down
Loading