[6.0] Add new trusted AKV URLs for FR and DE #3485
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added 4 new trusted AKV URLs. - Fixed existing manual tests and added unit tests.
There was a problem hiding this comment.
Pull Request Overview
This PR ports changes from main to release/6.0 that add support for 4 new trusted Azure Key Vault URLs for France and Germany sovereign clouds, along with corresponding test improvements. The changes ensure compatibility with C# 9.0 syntax requirements for the 6.0 release branch.
- Adds 4 new trusted AKV URLs for sovereign clouds (France and Germany)
- Improves test organization and adds comprehensive unit tests for URL validation
- Fixes C# 9.0 compatibility issues in exception handling
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Microsoft.Data.SqlClient.ManualTesting.Tests.csproj | Reorganizes test file references and adds new TrustedUrlsTest.cs |
| TrustedUrlsTest.cs | New comprehensive test class for validating trusted and untrusted AKV URLs |
| ExceptionTestAKVStore.cs | Updates to use shared error message generation from TrustedUrlsTest |
| Utils.cs | Changes return type from Exception to ArgumentException for better type safety |
| Constants.cs | Adds 4 new sovereign cloud AKV endpoints and improves code formatting |
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/TrustedUrlsTest.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #3482 from main to release/6.0