Skip to content

Commit 8299280

Browse files
author
Livar
authored
Merge pull request dotnet#6586 from ellismg/remove-core-clr-rid-property
Remove CoreCLRRid property
2 parents 58f709e + 3aa59d9 commit 8299280

File tree

7 files changed

+6
-10
lines changed

7 files changed

+6
-10
lines changed

TestAssets/TestPackages/PackageWithFakeNativeDep/PackageWithFakeNativeDep.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
<PropertyGroup>
33
<TargetFramework>net45</TargetFramework>
44
<AssemblyName>PackageWithFakeNativeDep</AssemblyName>
5-
<RuntimeIdentifiers>win7-x64;win7-x86;osx.10.11-x64;ubuntu.14.04-x64;ubuntu.16.04-x64;centos.7-x64;rhel.7.2-x64;debian.8-x64;osx.10.10-x64;rhel.7-x64</RuntimeIdentifiers>
65
</PropertyGroup>
76

87
<ItemGroup>

build/CrossGen.props

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<Project>
22
<PropertyGroup>
3-
<RuntimeNETCoreAppPackageName>runtime.$(CoreCLRRid).microsoft.netcore.app</RuntimeNETCoreAppPackageName>
3+
<RuntimeNETCoreAppPackageName>runtime.$(SharedFrameworkRid).microsoft.netcore.app</RuntimeNETCoreAppPackageName>
44
<CrossgenPath>$(NuGetPackagesDir)/$(RuntimeNETCoreAppPackageName)/$(CLI_SharedFrameworkVersion)/tools/crossgen$(ExeExtension)</CrossgenPath>
5-
<LibCLRJitPath>$(NuGetPackagesDir)/$(RuntimeNETCoreAppPackageName)/$(CLI_SharedFrameworkVersion)/runtimes/$(CoreCLRRid)/native/$(DynamicLibPrefix)clrjit$(DynamicLibExtension)</LibCLRJitPath>
5+
<LibCLRJitPath>$(NuGetPackagesDir)/$(RuntimeNETCoreAppPackageName)/$(CLI_SharedFrameworkVersion)/runtimes/$(SharedFrameworkRid)/native/$(DynamicLibPrefix)clrjit$(DynamicLibExtension)</LibCLRJitPath>
66
<SharedFrameworkNameVersionPath>$(OutputDirectory)/shared/$(SharedFrameworkName)/$(SharedFrameworkVersion)</SharedFrameworkNameVersionPath>
77
</PropertyGroup>
88
</Project>

build/Prepare.targets

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,8 @@
8080
<CallTarget Targets="CleanToolsLockFiles" />
8181

8282
<DotNetRestore ToolPath="$(Stage0Directory)"
83-
ProjectPath="&quot;%(RestoreToolsPackagesInput.FullPath)&quot;" />
83+
ProjectPath="&quot;%(RestoreToolsPackagesInput.FullPath)&quot;"
84+
AdditionalParameters="/p:UsePortableLinuxSharedFramework=$(UsePortableLinuxSharedFramework)" />
8485

8586
</Target>
8687

build/Stage0.props

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,5 @@
55
<DotnetStage0>$(Stage0Directory)/dotnet$(ExeExtension)</DotnetStage0>
66
<IsDesktopAvailable>False</IsDesktopAvailable>
77
<IsDesktopAvailable Condition=" '$(OSName)' == 'win' ">True</IsDesktopAvailable>
8-
<CoreCLRRid Condition=" '$(OSName)' == 'win' ">win-$(Architecture)</CoreCLRRid>
9-
<CoreCLRRid Condition=" '$(OSName)' == 'osx' ">osx-x64</CoreCLRRid>
10-
<CoreCLRRid Condition=" '$(CoreCLRRid)' == '' ">linux-x64</CoreCLRRid>
118
</PropertyGroup>
129
</Project>

build/test/TestPackageProjects.targets

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@
5959
<VersionPrefix>1.0.0</VersionPrefix>
6060
<VersionSuffix></VersionSuffix>
6161
<Clean>True</Clean>
62-
<MsbuildArgs>/p:RuntimeIdentifier=$(CoreCLRRid)</MsbuildArgs>
6362
</BaseTestPackageProject>
6463
<BaseTestPackageProject Include="TestAssets/TestPackages/dotnet-dependency-context-test">
6564
<Name>dotnet-dependency-context-test</Name>

dir.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@
3434
<Import Project="build/OutputDirectories.props" />
3535
<Import Project="build/BuildDefaults.props" />
3636
<Import Project="build/Stage0.props" />
37-
<Import Project="build/CrossGen.props" />
3837
<Import Project="build/VersionBadge.props" />
3938
<Import Project="build/BundledRuntimes.props" />
39+
<Import Project="build/CrossGen.props" />
4040
<Import Project="build/BackwardsCompatibilityRuntimes.props" />
4141

4242
<Import Project="build/AzureInfo.props" />

tools/CrossGen.Dependencies/CrossGen.Dependencies.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
<PropertyGroup>
55
<TargetFramework>netcoreapp2.0</TargetFramework>
6-
<RuntimeIdentifier>$(CoreCLRRid)</RuntimeIdentifier>
6+
<RuntimeIdentifier>$(SharedFrameworkRid)</RuntimeIdentifier>
77
</PropertyGroup>
88

99
<ItemGroup>

0 commit comments

Comments
 (0)