Skip to content

Commit 90d884b

Browse files
Merge pull request #10 from pottink/master
Make node version configurable
2 parents b2508a3 + b6c3e45 commit 90d884b

File tree

4 files changed

+12
-4
lines changed

4 files changed

+12
-4
lines changed

.env-sample

+8
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,14 @@ PHPVERSION=7.3
1717
# see https://github.com/dockerwest/nginx-symfony
1818
#
1919
NGINXVERSION=stable
20+
21+
#
22+
#
23+
# Choose your NodeJS version. To see which versions are available see
24+
# https://github.com/dockerwest/nodejs
25+
#
26+
NODEVERSION=10
27+
2028
#
2129
# set the symfony version, 3 and below use 3, 4 and above must use 4. Since the
2230
# intorduction of symfony4 there were some changes where web accessible files

bin/node

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ cmd = dockerrun + [
1717
'-v', currentpath + ":/nodeapp",
1818
'-e', "C_UID=" + env.get('C_UID'),
1919
'-e', "C_GID=" + env.get('C_GID'),
20-
'dockerwest/nodejs:8',
21-
'su-exec', 'node', 'node'
20+
'dockerwest/nodejs:' + env.get('NODEVERSION'),
21+
'node'
2222
] + sys.argv[1:]
2323

2424
os.execvp(cmd[0], cmd)

bin/npm

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ cmd = dockerrun + [
1919
'-v', currentpath + ":/nodeapp",
2020
'-e', "C_UID=" + env.get('C_UID'),
2121
'-e', "C_GID=" + env.get('C_GID'),
22-
'dockerwest/nodejs:8',
22+
'dockerwest/nodejs:' + env.get('NODEVERSION'),
2323
'npm'
2424
] + sys.argv[1:]
2525

bin/yarn

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ cmd = dockerrun + [
2020
'-v', currentpath + ":/nodeapp",
2121
'-e', "C_UID=" + env.get('C_UID'),
2222
'-e', "C_GID=" + env.get('C_GID'),
23-
'dockerwest/nodejs:8',
23+
'dockerwest/nodejs:' + env.get('NODEVERSION'),
2424
'yarn'
2525
] + sys.argv[1:]
2626

0 commit comments

Comments
 (0)