-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tags for every new version of node #3
Comments
yes we should always have tagged version for any dockerflie |
Could you please add tags? it should pretty straightforward, just tag the image everytime nodejs is updated... otherwise this image is quite difficult to use in production. We could have an alternative proper nodejs image, but since this is the official trusted one, it is really a shame that we can't use it just because you don't tag the images when building them. |
please add image tags! make this image useful! |
Well in case you want a proper tagged and also based on phusion-baseimage, you can get one here: |
Agreed, you can't just depend on |
Why is this not being addressed? Seems like a trivial change. |
@adam-beck: node.js (along with a whole bunch of other important bases) are actually covered in the Docker Hub by official images, e.g. https://registry.hub.docker.com/_/node/, which are carefully maintained, tagged etc. The "dockerfile" project, while often high up on the the Google results, contains mostly abandonware by comparison. |
the official image is based on Debian, which may or may not be what you need... |
Btw, this image was updated a month ago, so not being tagged may not be as much being abandonware as being lame :) |
@manast: not picking on this repo in particular, just my general observation of things under github.com/dockerfile, feel free to disagree. :) |
@manast how exactly tagging works? |
@nomadster you need to read docker images documentation, its quite basic stuff: https://docs.docker.com/userguide/dockerimages/ |
Oh seems pretty simple and legit. Let's see if I can find some time later to add this on the PR I've made (#7). |
👍 |
In order to use this image in production we need version tags.
The text was updated successfully, but these errors were encountered: