Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags for every new version of node #3

Open
manast opened this issue Aug 5, 2014 · 14 comments
Open

Add tags for every new version of node #3

manast opened this issue Aug 5, 2014 · 14 comments

Comments

@manast
Copy link

manast commented Aug 5, 2014

In order to use this image in production we need version tags.

@vvo
Copy link

vvo commented Sep 24, 2014

yes we should always have tagged version for any dockerflie

@manast
Copy link
Author

manast commented Oct 27, 2014

Could you please add tags? it should pretty straightforward, just tag the image everytime nodejs is updated... otherwise this image is quite difficult to use in production. We could have an alternative proper nodejs image, but since this is the official trusted one, it is really a shame that we can't use it just because you don't tag the images when building them.

@manast
Copy link
Author

manast commented Dec 12, 2014

please add image tags! make this image useful!

@manast
Copy link
Author

manast commented Dec 13, 2014

Well in case you want a proper tagged and also based on phusion-baseimage, you can get one here:
https://registry.hub.docker.com/u/optimalbits/nodejs/

@jareware
Copy link

Agreed, you can't just depend on latest and hope stuff works. Tags would be hugely appreciated.

@adam-beck
Copy link
Contributor

Why is this not being addressed? Seems like a trivial change.

@jareware
Copy link

@adam-beck: node.js (along with a whole bunch of other important bases) are actually covered in the Docker Hub by official images, e.g. https://registry.hub.docker.com/_/node/, which are carefully maintained, tagged etc.

The "dockerfile" project, while often high up on the the Google results, contains mostly abandonware by comparison.

@manast
Copy link
Author

manast commented Jan 20, 2015

the official image is based on Debian, which may or may not be what you need...

@manast
Copy link
Author

manast commented Jan 20, 2015

Btw, this image was updated a month ago, so not being tagged may not be as much being abandonware as being lame :)

@jareware
Copy link

@manast: not picking on this repo in particular, just my general observation of things under github.com/dockerfile, feel free to disagree. :)

@nomadster
Copy link

@manast how exactly tagging works?

@manast
Copy link
Author

manast commented Jan 21, 2015

@nomadster you need to read docker images documentation, its quite basic stuff: https://docs.docker.com/userguide/dockerimages/

@nomadster
Copy link

Oh seems pretty simple and legit. Let's see if I can find some time later to add this on the PR I've made (#7).

@ghost
Copy link

ghost commented Feb 17, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants