Skip to content

Commit dd4fa06

Browse files
authored
Merge pull request #160 from crazy-max/node12
Revert to Node 12 as default runtime
2 parents bb984ef + 4e35385 commit dd4fa06

File tree

4 files changed

+9
-29
lines changed

4 files changed

+9
-29
lines changed

Diff for: action.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,6 @@ inputs:
2626
required: false
2727

2828
runs:
29-
using: 'node16'
29+
using: 'node12'
3030
main: 'dist/index.js'
3131
post: 'dist/index.js'

Diff for: hack/build.Dockerfile renamed to dev.Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# syntax=docker/dockerfile:1.3-labs
22

3-
ARG NODE_VERSION
3+
ARG NODE_VERSION=12
44
ARG DOCKER_VERSION=20.10.10
55
ARG BUILDX_VERSION=0.7.0
66

Diff for: docker-bake.hcl

+7-24
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,3 @@
1-
variable "NODE_VERSION" {
2-
default = "16"
3-
}
4-
5-
target "node-version" {
6-
args = {
7-
NODE_VERSION = NODE_VERSION
8-
}
9-
}
10-
111
group "default" {
122
targets = ["build"]
133
}
@@ -21,50 +11,43 @@ group "validate" {
2111
}
2212

2313
target "build" {
24-
inherits = ["node-version"]
25-
dockerfile = "./hack/build.Dockerfile"
14+
dockerfile = "dev.Dockerfile"
2615
target = "build-update"
2716
output = ["."]
2817
}
2918

3019
target "build-validate" {
31-
inherits = ["node-version"]
32-
dockerfile = "./hack/build.Dockerfile"
20+
dockerfile = "dev.Dockerfile"
3321
target = "build-validate"
3422
output = ["type=cacheonly"]
3523
}
3624

3725
target "format" {
38-
inherits = ["node-version"]
39-
dockerfile = "./hack/build.Dockerfile"
26+
dockerfile = "dev.Dockerfile"
4027
target = "format-update"
4128
output = ["."]
4229
}
4330

4431
target "format-validate" {
45-
inherits = ["node-version"]
46-
dockerfile = "./hack/build.Dockerfile"
32+
dockerfile = "dev.Dockerfile"
4733
target = "format-validate"
4834
output = ["type=cacheonly"]
4935
}
5036

5137
target "vendor-update" {
52-
inherits = ["node-version"]
53-
dockerfile = "./hack/build.Dockerfile"
38+
dockerfile = "dev.Dockerfile"
5439
target = "vendor-update"
5540
output = ["."]
5641
}
5742

5843
target "vendor-validate" {
59-
inherits = ["node-version"]
60-
dockerfile = "./hack/build.Dockerfile"
44+
dockerfile = "dev.Dockerfile"
6145
target = "vendor-validate"
6246
output = ["type=cacheonly"]
6347
}
6448

6549
target "test" {
66-
inherits = ["node-version"]
67-
dockerfile = "./hack/build.Dockerfile"
50+
dockerfile = "dev.Dockerfile"
6851
target = "test-coverage"
6952
output = ["./coverage"]
7053
}

Diff for: package.json

-3
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@
1313
"type": "git",
1414
"url": "git+https://github.com/docker/login-action.git"
1515
},
16-
"engines": {
17-
"node": "^16"
18-
},
1916
"keywords": [
2017
"actions",
2118
"docker",

0 commit comments

Comments
 (0)