memo: Return ErrKeyNotFound from Delete and List when appropriate.

Matthieu Nottale · Matthieu Nottale · commit 40c98f7e4543 · 2017-08-07T14:27:32.000+02:00
diff --git a/store/memo/memo.go b/store/memo/memo.go
@@ -55,6 +55,9 @@ func (s *Memo) Put(key string, value []byte, options *store.WriteOptions) error
 // Delete value at "key"
 func (s *Memo) Delete(key string) error {
 	_, err := s.kvs.Delete(context.Background(), &kvs.DeleteRequest{Key: key})
+	if err != nil && grpc.Code(err) == codes.NotFound {
+		return store.ErrKeyNotFound
+	}
 	return err
 }
 
@@ -100,6 +103,9 @@ func (s *Memo) List(directory string) ([]*store.KVPair, error) {
 		}
 		res = append(res, kv)
 	}
+	if len(res) == 0 {
+		return nil, store.ErrKeyNotFound
+	}
 	return res, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,9 @@ func (s Memo) Put(key string, value []byte, options store.WriteOptions) error`
`55`	`55`	`// Delete value at "key"`
`56`	`56`	`func (s *Memo) Delete(key string) error {`
`57`	`57`	`_, err := s.kvs.Delete(context.Background(), &kvs.DeleteRequest{Key: key})`
	`58`	`+ if err != nil && grpc.Code(err) == codes.NotFound {`
	`59`	`+ return store.ErrKeyNotFound`
	`60`	`+ }`
`58`	`61`	`return err`
`59`	`62`	`}`
`60`	`63`
`@@ -100,6 +103,9 @@ func (s Memo) List(directory string) ([]store.KVPair, error) {`
`100`	`103`	`}`
`101`	`104`	`res = append(res, kv)`
`102`	`105`	`}`
	`106`	`+ if len(res) == 0 {`
	`107`	`+ return nil, store.ErrKeyNotFound`
	`108`	`+ }`
`103`	`109`	`return res, nil`
`104`	`110`	`}`
`105`	`111`