Merge pull request #197 from docker/correct-builtin-args-list

Include BUILDKIT_SYNTAX in the list of built-in ARGs

Author: rcjsuen

CHANGELOG.md

@@ -4,6 +4,8 @@ All notable changes to the Docker Language Server will be documented in this fil
 
  ## [Unreleased]
 
+### Added
+
 - Dockerfile
   - textDocument/hover
     - support configuring vulnerability hovers with an experimental setting ([#192](https://github.com/docker/docker-language-server/issues/192))
@@ -17,6 +19,12 @@ All notable changes to the Docker Language Server will be documented in this fil
   - textDocument/publishDiagnostics
     - support filtering vulnerability diagnostics with an experimental setting ([#192](https://github.com/docker/docker-language-server/issues/192))
 
+### Fixed
+
+- Bake
+  - textDocument/publishDiagnostics
+    - stop flagging `BUILDKIT_SYNTAX` as an unrecognized `ARG` ([#187](https://github.com/docker/docker-language-server/issues/187))
+
 ## [0.7.0] - 2025-05-09
 
 ### Added

internal/bake/hcl/diagnosticsCollector.go

@@ -32,6 +32,7 @@ var builtinArgs = []string{
 	"BUILDKIT_CACHE_MOUNT_NS",
 	"BUILDKIT_MULTI_PLATFORM",
 	"BUILDKIT_SANDBOX_HOSTNAME",
+	"BUILDKIT_SYNTAX",
 	"BUILDKIT_DOCKERFILE_CHECK",
 	"BUILDKIT_CONTEXT_KEEP_GIT_DIR",
 	"SOURCE_DATE_EPOCH",

internal/bake/hcl/diagnosticsCollector_test.go

@@ -127,7 +127,7 @@ func TestCollectDiagnostics(t *testing.T) {
 		},
 		{
 			name:        "args references built-in args",
-			content:     "target \"t1\" {\n  args = {\n    HTTP_PROXY = \"\"\n    HTTPS_PROXY = \"\"\n    FTP_PROXY = \"\"\n    NO_PROXY = \"\"\n    ALL_PROXY = \"\"\n  }\n}",
+			content:     "target \"t1\" {\n  args = {\n    HTTP_PROXY = \"\"\n    HTTPS_PROXY = \"\"\n    FTP_PROXY = \"\"\n    NO_PROXY = \"\"\n    ALL_PROXY = \"\"\n    BUILDKIT_SYNTAX = \"\"\n  }\n}",
 			diagnostics: []protocol.Diagnostic{},
 		},
 		{