Skip to content

Commit cc254e8

Browse files
authoredFeb 27, 2025··
Unset NOTIFY_SOCKET when running the temporary server. (#1325)
* Unset NOTIFY_SOCKET when running the temporary server. Postgres has native support for this notification socket and will write a `READY=1` message once it is ready and accepting connections. Unfortunately, the temporary server used by the `docker-entrypoint.sh` also sends a message on the socket, making it appear as though the container is ready and serving connections when it is not.
1 parent 729d22b commit cc254e8

21 files changed

+63
-0
lines changed
 

‎13/alpine3.20/docker-entrypoint.sh

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎13/alpine3.21/docker-entrypoint.sh

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎13/bookworm/docker-entrypoint.sh

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎13/bullseye/docker-entrypoint.sh

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎14/alpine3.20/docker-entrypoint.sh

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎14/alpine3.21/docker-entrypoint.sh

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎14/bookworm/docker-entrypoint.sh

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎14/bullseye/docker-entrypoint.sh

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎15/alpine3.20/docker-entrypoint.sh

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎15/alpine3.21/docker-entrypoint.sh

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎15/bookworm/docker-entrypoint.sh

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎15/bullseye/docker-entrypoint.sh

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎16/alpine3.20/docker-entrypoint.sh

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎16/alpine3.21/docker-entrypoint.sh

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎16/bookworm/docker-entrypoint.sh

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎16/bullseye/docker-entrypoint.sh

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎17/alpine3.20/docker-entrypoint.sh

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎17/alpine3.21/docker-entrypoint.sh

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎17/bookworm/docker-entrypoint.sh

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎17/bullseye/docker-entrypoint.sh

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎docker-entrypoint.sh

+3
Original file line numberDiff line numberDiff line change
@@ -269,6 +269,9 @@ docker_temp_server_start() {
269269
# does not listen on external TCP/IP and waits until start finishes
270270
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
271271

272+
# unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
273+
# any process supervisor.
274+
NOTIFY_SOCKET= \
272275
PGUSER="${PGUSER:-$POSTGRES_USER}" \
273276
pg_ctl -D "$PGDATA" \
274277
-o "$(printf '%q ' "$@")" \

0 commit comments

Comments
 (0)
Please sign in to comment.