Skip to content

Commit 3a3367f

Browse files
authored
Patch cycle - 2025 / Cycle 2 (#459)
The changes to go out in the next version (5.0.0) are: CHANGED: Dependency updates REMOVED: DomainCollaborators have been removed. Please use our Domain Access Control feature. Belongs to dnsimple/dnsimple-engineering#302 Belongs to dnsimple/dnsimple-engineering#294
1 parent 9e244f6 commit 3a3367f

File tree

5 files changed

+5
-121
lines changed

5 files changed

+5
-121
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ This project uses [Semantic Versioning 2.0.0](http://semver.org/).
44

55
## main
66

7+
- CHANGED: Dependency updates
8+
- REMOVED: `DomainCollaborators` have been removed. Please use our Domain Access Control feature.
9+
710
## 4.0.0
811

912
- NEW: Added `alias_email` and `destination_email` to `EmailForward`

LICENSE.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
The MIT License (MIT)
22

3-
Copyright (c) 2024 DNSimple Corporation
3+
Copyright (c) 2025 DNSimple Corporation
44

55
Permission is hereby granted, free of charge, to any person obtaining a copy
66
of this software and associated documentation files (the "Software"), to deal

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,4 +143,4 @@ Contibutions are welcomed. Please open an issue to discuss the changes before op
143143

144144
## License
145145

146-
Copyright (c) 2024 DNSimple Corporation. This is Free Software distributed under the MIT license.
146+
Copyright (c) 2025 DNSimple Corporation. This is Free Software distributed under the MIT license.

dnsimple/service/domains.py

Lines changed: 0 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -99,71 +99,6 @@ def delete_domain(self, account_id, domain):
9999
response = self.client.delete(f'/{account_id}/domains/{domain}')
100100
return Response(response)
101101

102-
def list_collaborators(self, account_id, domain):
103-
"""
104-
List collaborators for the domain in the account.
105-
106-
See https://developer.dnsimple.com/v2/domains/collaborators/#listDomainCollaborators
107-
108-
:param account_id: int
109-
The account ID
110-
:param domain: int/str
111-
The domain name or id
112-
:return: dnsimple.Response
113-
A list of collaborators for the domain in the account
114-
"""
115-
warnings.warn("DEPRECATION WARNING: `DomainCollaborators` have been deprecated and will be removed in the next major version. Please use our Domain Access Control feature.")
116-
response = self.client.get(f'/{account_id}/domains/{domain}/collaborators')
117-
return Response(response, Collaborator)
118-
119-
def add_collaborator(self, account_id, domain, email):
120-
"""
121-
Adds a collaborator for the domain in the account
122-
123-
At the time of the add, a collaborator may or may not have a DNSimple account.
124-
125-
In case the collaborator doesn't have a DNSimple account, the system will invite her/him to register to
126-
DNSimple first and then to accept the collaboration invitation.
127-
128-
In the other case, she/he is automatically added to the domain as collaborator. She/he can decide to reject
129-
the invitation later.
130-
131-
See https://developer.dnsimple.com/v2/domains/collaborators/#addDomainCollaborator
132-
133-
:param account_id: int
134-
The account ID
135-
:param domain: int/str
136-
The domain name or id
137-
:param email: str
138-
The email of the collaborator to be added
139-
140-
:return: dnsimple.Response
141-
The collaborator added to the domain in the account
142-
"""
143-
warnings.warn("DEPRECATION WARNING: `DomainCollaborators` have been deprecated and will be removed in the next major version. Please use our Domain Access Control feature.")
144-
response = self.client.post(f'/{account_id}/domains/{domain}/collaborators', data=json.dumps({'email': email}))
145-
return Response(response, Collaborator)
146-
147-
def remove_collaborator(self, account_id, domain, collaborator):
148-
"""
149-
Remove a collaborator from the domain in the account
150-
151-
See https://developer.dnsimple.com/v2/domains/collaborators/#removeDomainCollaborator
152-
153-
:param account_id: int
154-
The account ID
155-
:param domain: int/str
156-
The domain name or id
157-
:param collaborator: int
158-
The collaborator id
159-
160-
:return: dnsimple.Response
161-
An empty response
162-
"""
163-
warnings.warn("DEPRECATION WARNING: `DomainCollaborators` have been deprecated and will be removed in the next major version. Please use our Domain Access Control feature.")
164-
response = self.client.delete(f'/{account_id}/domains/{domain}/collaborators/{collaborator}')
165-
return Response(response)
166-
167102
def enable_dnssec(self, account_id, domain):
168103
"""
169104
Enable DNSSEC for the domain in the account. This will sign the zone. If the domain is registered it will also

tests/service/domains_collaborators_test.py

Lines changed: 0 additions & 54 deletions
This file was deleted.

0 commit comments

Comments
 (0)