-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced support for record classes #60
Comments
@xeals Do you have any more hints about how to identify the canonical constructor? I couldn't sniff out the flags you mentioned. |
I'd not recorded the info when I was playing around (of course), but I rediscovered what I was talking about. Unfortunately this was found through a debugger and I didn't realise it exposes javac internals, which in JDK16+ are a little harder to access than they used to be (doable, just requiring opt-in flags). With that in mind:
It doesn't look like any of this is transferred to a properly public API, so deciding to opt into those private APIs might be a bigger decision than just adding support. Looking at it again I would be hesitant. |
Thanks for digging into this again, Alex. I agree we should stick to the public API. I wonder if we could infer the signature of the canonical constructor by paying attention to the |
Implement the features suggested by @xeals in #52:
GENERATED
orRECORD
flags set on the method (which I think is specified, but I can't find the exact mention in the JVM spec)@param
tags from the primary constructor could be applied to the fields and/or methodsThe text was updated successfully, but these errors were encountered: