diff1_inline is showing diffs on the normal buffer intermittently (when diffview tab is open)

[charbelnicolas]

While having diff1_inline enabled as default

	view = {
		default = { layout = "diff1_inline" },
		inline = {
			deletion_highlight = "full_width"
		}
	},

I can see the diffing in the normal buffer too while the diffview tab is open. When I close the diffview tab the diffing disappears from the normal (non-diffview) buffer/tab.

diff_bug.mp4

Also, for the tree-sitter highlights, the comments are sometimes not getting the proper highlighting. Sometimes they show with white foreground color and sometimes they do respect the comment highlight color.

[dlyongemallo]

@charbelnicolas Which nvim version and OS are you using?

[charbelnicolas]

@charbelnicolas Which nvim version and OS are you using?

NVIM v0.12.2
Build type: RelWithDebInfo
LuaJIT 2.1.1774896198

Linux 7.0.3-arch1-2 x86_64 GNU/Linux

[dlyongemallo]

@charbelnicolas Should be fixed. Please re-open if the fix doesn't work for you.

[charbelnicolas]

Hi @dlyongemallo it is working now, thank you. Just the nested comments inside functions and variables (anything that isn't in the main scope) still appear with a white foreground color instead of its proper tree-sitter highlight.

Other than that, it is working pretty well, thank you!

[dlyongemallo]

@charbelnicolas Can you give me an example repro case? If the deletions span a scope boundary, it may be impossible to get tree-sitter to highlight them properly in the diff1 layout, since the deleted chunks are fed into tree-sitter without the surrounding context. (This is unlike the diff2 layouts, where the LHS is parsed together as an entire file.)

[dlyongemallo]

@charbelnicolas I think #159 should fix this.

[charbelnicolas]

@charbelnicolas I think #159 should fix this.

Yes, it's working now! Thank you!