Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail is not copied from exifData when using SetProfile #1365

Closed
Kjelldor opened this issue Mar 24, 2023 · 2 comments
Closed

Thumbnail is not copied from exifData when using SetProfile #1365

Kjelldor opened this issue Mar 24, 2023 · 2 comments

Comments

@Kjelldor
Copy link

Kjelldor commented Mar 24, 2023

Magick.NET version

Magick.NET-Q8-AnyCPU v13.0.0.0

Environment (Operating system, version and so on)

Windows 11 version 22H2, x64 based AMD processor

Description

I noticed that the SetProfile function doesn't actually copy all the values to the new object correctly.

For one, the thumbnailValue is left behind, as are the values for the thumbnailLength and thumbnailOffset.
However, when looking a bit deeper, I found that my IExifProfile has 36 values, while my new ExifProfile after:
img.SetProfile(profile); var profile2 = img2.GetExifProfile();
It suddenly only has 29 values and the thumbnailLength and offset are set to 0.
As you can see in the following screenshots when I debug, the value clearly changes after being set to a magickImage:
Profile before:
example1
Profile after:
example2

Steps to Reproduce

To reproduce this, you can use any two .jpg images. I have not yet tried this with other imageTypes, nor have I very extensively tested it. I have used a couple of .jpg images to see if it was something on my side, two of which you can download here to try for yourself: https://github.com/ianare/exif-samples I used the 'Canon_40D.jpg' and 'Kodak_CX7530.jpg' images from there. They did copy all other data from each other, except the information about the thumbnails.

If I have some time tomorrow I'll make sure to post an update concerning .png, .tiff and .bmp images.

@Kjelldor
Copy link
Author

I just noticed this issue has been brought up before in issue #605 I will therefore close this issue, as duplicates seem unnecessary.

My apologies for the doubled information.

@Kjelldor Kjelldor closed this as not planned Won't fix, can't repro, duplicate, stale Mar 24, 2023
@dlemstra
Copy link
Owner

Thanks for closing this duplicate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants