Merge pull request #5741 from dunkyp/issue_17832

Fix Issue 17832 - std.random.choice cannot be used with other random generators

Author: wilzbach

std/random.d

@@ -2018,7 +2018,7 @@ Returns:
     a copy.
  */
 auto ref choice(Range, RandomGen = Random)(auto ref Range range,
-                                           ref RandomGen urng = rndGen)
+                                           ref RandomGen urng)
 if (isRandomAccessRange!Range && hasLength!Range && isUniformRNG!RandomGen)
 {
     assert(range.length > 0,
@@ -2027,6 +2027,12 @@ if (isRandomAccessRange!Range && hasLength!Range && isUniformRNG!RandomGen)
     return range[uniform(size_t(0), $, urng)];
 }
 
+/// ditto
+auto ref choice(Range)(auto ref Range range)
+{
+    return choice(range, rndGen);
+}
+
 ///
 @safe unittest
 {
@@ -2041,6 +2047,10 @@ if (isRandomAccessRange!Range && hasLength!Range && isUniformRNG!RandomGen)
     auto urng = Random(unpredictableSeed);
     elem = choice(array, urng);
 
+    assert(canFind(array, elem),
+           "Choice did not return a valid element from the given Range");
+    auto rng2 = Xorshift();
+    elem = choice(array, rng2);
     assert(canFind(array, elem),
            "Choice did not return a valid element from the given Range");
 }