Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

names.push is not a function #7

Open
westonganger opened this issue May 2, 2017 · 2 comments
Open

names.push is not a function #7

westonganger opened this issue May 2, 2017 · 2 comments

Comments

@westonganger
Copy link

I was getting the following error from your plugin

names.push is not a function

I dug into it and its related to the dependency injection library: dependable. The library is in poor shape and should be dropped.
@westonganger
Copy link
Author

It wasnt dependable. It was lodash for some odd reason. The only real reason you were using lodash for was the _.range function but that was so easily replaceable.

Once I removed lodash from the project it start working.

I will create a PR with all my fixes soon.

@westonganger westonganger changed the title Plugin broken because of the library: dependable names.push is not a function May 2, 2017
@westonganger westonganger mentioned this issue May 2, 2017
Open
@westonganger
Copy link
Author

Just created PR #8 which fixes this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@westonganger