-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing vhea, vmtx and VORG tables #67
Comments
Thanks for the message, @justvanrossum! No, this is not to be expected. :-) The vertical spacing information is included in the (Note that the final line in Bungee shade is set with an Opaque white Regular layer to manage the Aring overlap...the hollow counters issue in the basic Shade is kind of a separate unresolved issue) Do you happen to know why the If you believe that vhea, vmtx, and VORG tables are a better solution, do you have an implementation of these tables that you could recommend I use as an exemplar? Thanks again! |
Ahh, turning on But yes, I think it would be better if the vertical advances (and origins) are the right ones to begin with, instead of having them "touched up" by UFO3 supports these settings (with http://unifiedfontobject.org/versions/ufo3/glyphs/glif/#advance and the How to conveniently edit them is another story, but given you have all the necessary information available in |
(Btw. |
One more thing: only the otfs work correctly with harfbuzz (when turning on |
I made a messy little script that takes your vpal.fea file, a source ttf or otf, and adds I have attached the result of running this on Bungee-Regular.ttf from the Bungee_Basic folder. And the script itself, which contains hard-coded paths, so needs tweaking before you can run it. The resulting ttf behaves perfectly with harfbuzz, without the need for |
I just checked the spec: |
Just, you are the best! 🙌 Thanks so much for putting together this script so I can see how the tables are supposed to look. I’ll be happy to integrate the contents of this script into the build process so that the work is done by the Leaving this issue open until I get around to it... |
No problem! Ideally your vpal data should be incorporated into the source UFOs as |
When doing vertical layout using harfbuzz, I notice that the vertical advances are all the same (1000). Vertical kerning works, but the vertical spacing is too wide, and uneven for glyphs that have accents.
Is this to be expected?
This should be fixable by adding
vhea
,vmtx
andVORG
tables. Maybe a 2020 update would be a nice project? @davelab6? 😊The text was updated successfully, but these errors were encountered: