Skip to content

Django 3.2 compatibility #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tenzer opened this issue Apr 7, 2021 · 2 comments · Fixed by #908
Closed

Django 3.2 compatibility #907

Tenzer opened this issue Apr 7, 2021 · 2 comments · Fixed by #908

Comments

@Tenzer
Copy link
Contributor

Tenzer commented Apr 7, 2021

Django 3.2 is now out, but we are currently blocked on upgrading to it due to djangorestframework-jsonapi specifically disallows that and newer versions as dependencies:

"django>=2.2,<3.2",

I couldn't find any other issues related to this so thought I would create one.

Are there any specific concerns with loosening the version constraint so users of this library also can upgrade to Django 3.2?

@sliverc
Copy link
Member

sliverc commented Apr 7, 2021

We want to specify each supported release of Django or other dependencies to make sure it actually works by running the test suite through it. See for instance #822 where Django 3.1 had been added and quite a bit of changes were needed.

Currently DRF has released a version which officially supports Django 3.2. This said I would be fine adding Django 3.2 support in DJA before DRF has a new release as long as the test suite runs through.

PR is welcome.

@Tenzer Tenzer mentioned this issue Apr 7, 2021
5 tasks
@Tenzer
Copy link
Contributor Author

Tenzer commented Apr 7, 2021

Thanks! I have made a PR to bump the compatibility in #908.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants