Custom Config Path Not Picked Up in django-tailwind-cli Build Command

[udit-001]

Hi,

I recently switched from using django-tailwind to django-tailwind-cli in one of my projects because it doesn't require installation on my machine. I appreciate all the great work you've done on this project!

I was using this setup with DaisyUI v4 and Tailwind v3, which required me to use version 2.21.1 of this package. To enable DaisyUI support, I used the TAILWIND_CLI_SRC_REPO configuration to point to tailwind-cli-extra. Additionally, since I already had existing files from my django-tailwind setup, I configured the TAILWIND_CLI_CONFIG_FILE to point to one of those files.

However, I noticed that my custom configuration file was not being picked up correctly during the build process.

To identify the issue, I examined the code and discovered that the build command was not passing the custom config path to the CLI. Specifically, I found the problem in the way the build command was constructed.

v2.21.1 Changes

I suggest the following fixes here to address the issue:

def _get_build_cmd(*, minify: bool = True, watch: bool = False) -> list[str]:
    build_cmd = [
        str(utils.get_full_cli_path()),
+       "--config",
+       str(utils.get_full_config_file_path()),
        "--output",
        str(utils.get_full_dist_css_path()),
    ]

    if minify:
        build_cmd.append("--minify")

    if watch:
        build_cmd.append("--watch")

    if conf.get_tailwind_cli_src_css() is not None:
        build_cmd.extend(
            [
                "--input",
                str(utils.get_full_src_css_path()),
            ]
        )
    return build_cmd

v4.1.10 Changes

I also tried upgrading to the latest version of the package and ran into the same problem, where the custom config path was not being passed to the CLI. After examining the code, I discovered that the issue lies in the way the build command is constructed.

I would suggest making the following changes here to address this issue:

    @property
    def build_cmd(self) -> list[str]:
        result = [
            str(self.cli_path),
            "--output",
            str(self.dist_css),
            "--minify",
        ]

+       if self.config_file:
+           result.extend(["--config", str(self.config_file)])

        if self.src_css:
            result.extend(["--input", str(self.src_css)])

        return result

If you're open to it, I have opened a PR #156 that could address this. It would be great if you could review and, if it looks good, merge it.

[oliverandrich]

Thanks for the ticket and the pull request. I am currently looking into it. I worked a bit on a solution for #152, which tries to solve this issue too. But in a different way.

[oliverandrich]

For the 4.x version, I found an alternative solution to solve this, as the CLI doesn't have a --config option any longer. It can be given on the command line, but it doesn't seem to have any effect.

≈ tailwindcss v4.0.6

Usage:
  tailwindcss [--input input.css] [--output output.css] [--watch] [options…]

Options:
  -i, --input ··········· Input file
  -o, --output ·········· Output file [default: `-`]
  -w, --watch ··········· Watch for changes and rebuild as needed
  -m, --minify ·········· Optimize and minify the output
      --optimize ········ Optimize the output without minifying
      --cwd ············· The current working directory [default: `.`]

If you still need a tailwind.config.js for adding some plugins or so, it has to be done with a @config directive.

https://tailwindcss.com/docs/upgrade-guide#using-a-javascript-config-file

django-tailwind-cli has now proper support for tailwind-cli-extraand daisyUI through the changes for the next version.

But for the 2.x branch, I will add your solution. I totally missed this aspect.

It took a bit longer to make up my mind about it, and I also had to change my point of view since we talked about your pull request.

Checkout version 4.2.2. https://github.com/django-commons/django-tailwind-cli/releases/tag/4.2.2

[udit-001]

Thanks for v4.2.2. Daisyui setup seems much simpler now.
However, as I am still using Tailwind v3 and DaisyUI v4, I would likely need the updated patch for version 2.x.

Please let me know if you'd like me to create a pull request. Alternatively, if you plan to handle it yourself, I would be happy to help test it once the patch is released.

[oliverandrich]

I will work on this tonight and plan to release a bug fix tomorrow morning.

[udit-001]

Hey, hope you're doing well. It's been a while - just checking in to see if you were able to work on a fix for this.

If not, let me know if I can help in any way. I'd be happy to help get this out.

[oliverandrich]

@udit-001 Sorry for the late response. I released a version for 4.x today. I will try to release a fix for the other branch tomorrow.

[oliverandrich]

It took way longer than I thought. I have fixed this in the tag 2.22.0.

https://github.com/django-commons/django-tailwind-cli/tree/2.22.0

But my problem at the moment is, that the django-commons pipeline is not able to publish a proper release to PyPI. Until I have solved this with Django-commons admins, you have to checkout the git tag.

[oliverandrich]

Release 2.22.1 to address the problem from the ticket and my build problems.

https://pypi.org/project/django-tailwind-cli/2.22.1/