Skip to content

Commit e68f0c4

Browse files
committed
DEV: Skip core features specs on stable (#269)
The shared example is not available in stable yet
1 parent d5f5e93 commit e68f0c4

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed
Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,15 @@
11
import Route from "@ember/routing/route";
22

33
export default class UpgradeIndex extends Route {
4-
model() {
5-
return this.modelFor("update");
4+
async model() {
5+
const model = this.modelFor("update");
6+
await this.loadRepos(model);
7+
return model;
68
}
79

810
async loadRepos(list) {
911
for (const repo of list) {
1012
await repo.findLatest();
1113
}
1214
}
13-
14-
setupController(controller, model) {
15-
super.setupController(...arguments);
16-
this.loadRepos(model);
17-
}
1815
}

spec/system/admin_update_spec.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
before { sign_in(admin) }
1010

11-
xit "displays the admin update page with the right repositories" do
11+
it "displays the admin update page with the right respositories" do
1212
visit("/admin/update")
1313

1414
expect(page).to have_css("h3", exact_text: I18n.t("js.admin.docker.update_title"))
@@ -17,7 +17,5 @@
1717
expect(page).to have_css(
1818
"tr.repo .d-admin-row__overview-about a[href='https://meta.discourse.org/t/12655']",
1919
)
20-
ensure
21-
puts page.html if ENV["CI"]
2220
end
2321
end

spec/system/core_features_spec.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
# frozen_string_literal: true
22

33
RSpec.describe "Core features", type: :system do
4+
# TODO: Stop skipping when shared example is available in stable
5+
next if Discourse.git_branch == "stable"
6+
47
before { enable_current_plugin }
58

69
it_behaves_like "having working core features"

0 commit comments

Comments
 (0)